Open
Conversation
Now the result is this:
/**
* [test description]
* @param [type] $argument [description]
* @param type $argument2 [description]
* @param ArfFof $arg3 [description]
* @param string $arg4 [description]
* @param array $Arg5 [description]
* @param [type] $arg6 [description]
* @param string $arg7 [description]
* @param int $arg8 [description]
* @param array $arg9 [description]
* @param ArgArray $arg10 [description]
* @param [type] ...$arg11 [description]
* @return [type] [description]
*/
public function test($argument, type $argument2, Arf\Fof $arg3, $arg4 = 'value', $Arg5 = [], $arg6 = null, $arg7 = '', $arg8 = 8, Arg\Array $arg9 = [], Arg\Array $arg10, ...$arg11)
Examples:
/**
* [testWithType description]
* @return [type] [description]
*/
public function testWithType()
{
}
/**
* [testReturnArray description]
* @return array [description]
*/
public function testReturnArray() :array {
}
/**
* [testReturnArrayOrNull description]
* @return array|null [description]
*/
public function testReturnArrayOrNull() :?array {
}
/**
* [testReturnErrorType description]
* @return [type] [description]
*/
public function testReturnErrorType() :??array {
}
The last pull request fixed (nikhilkalige#348). Issue nikhilkalige#309 fixed. The modifiers don't depend from their sequence.
dmitrach
changed the title
Collaborator
|
Sorry, I've never got around to reviewing this. Keep in mind this package is pretty much unmaintained but I am still willing to merge clean PRs and publish new releases. This PR seems to be that. Also fixing a lot of old bugs would be great. If anyone is willing to make sure this still works, I'd love to merge this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now the result is this:
/**
* [test description]
* @param [type] $argument [description]
* @param type $argument2 [description]
* @param ArfFof $arg3 [description]
* @param string $arg4 [description]
* @param array $Arg5 [description]
* @param [type] $arg6 [description]
* @param string $arg7 [description]
* @param int $arg8 [description]
* @param array $arg9 [description]
* @param ArgArray $arg10 [description]
* @param [type] ...$arg11 [description]
* @return [type] [description]
*/
public function test($argument, type $argument2, Arf\Fof $arg3, $arg4 = 'value', $Arg5 = [], $arg6 = null, $arg7 = '', $arg8 = 8, Arg\Array $arg9 = [], Arg\Array $arg10, ...$arg11)