Skip to content

fixes #15797; allows calling generic procs even if the proc name is surrounded with parentheses #25479

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
demotomohiro wants to merge 6 commits into
base: devel
Choose a base branch
from
Open

fixes #15797; allows calling generic procs even if the proc name is surrounded with parentheses #25479

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
a0849c3
fixes #15797
demotomohiro Feb 3, 2026
888a46e
don't check zeroDefault func
demotomohiro Feb 3, 2026
d110ca0
don't check sizeof to fix errors
demotomohiro Feb 3, 2026
ff929d5
don't print error when there is an error
demotomohiro Feb 4, 2026
1b21860
don't check in concept
demotomohiro Feb 6, 2026
ccbafba
don't check typeof
demotomohiro Feb 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion compiler/semexprs.nim
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1105,7 +1105,7 @@ proc semIndirectOp(c: PContext, n: PNode, flags: TExprFlags; expectedType: PType
let t = n[0].typ
if t != nil and t.kind in {tyVar, tyLent}:
n[0] = newDeref(n[0])
elif isSymChoice(n[0]) and nfDotField notin n.flags:
elif (isSymChoice(n[0]) or (n[0].kind == nkSym and isGenericRoutineStrict(n[0].sym))) and nfDotField notin n.flags:
# overloaded generic procs e.g. newSeq[int] can end up here
return semDirectOp(c, n, flags, expectedType)

Expand Down
13 changes: 13 additions & 0 deletions compiler/sempass2.nim
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1077,6 +1077,19 @@ proc trackCall(tracked: PEffects; n: PNode) =
if n.typ != nil:
if tracked.owner.kind != skMacro and n.typ.skipTypes(abstractVar).kind != tyOpenArray:
createTypeBoundOps(tracked, n.typ, n.info)
if tracked.c.matchedConcept == nil and a.kind == nkSym:
if a.sym.isGenericRoutineStrict() and a.sym.magic notin {mSizeOf, mZeroDefault, mTypeOf}:
# this error is likely a compiler bug

# it is not instantiated if there is an error
var hasErrorType = false
for i in 1..<n.len:
let nt = n[i].typ
if nt.kind == tyError:
hasErrorType = true
break
if not hasErrorType:
localError(tracked.config, a.info, "calling generic procedure without instantiation: $1" % a.sym.name.s)

when defined(nimsuggest):
var actualLoc = a.info
Expand Down
Loading