Skip to content

Reject trailing commas inside JSON arrays and objects #25491

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
planetis-m wants to merge 2 commits into
base: devel
Choose a base branch
from
+12 −4
Open

Reject trailing commas inside JSON arrays and objects #25491

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b47e223
Refactor JSON parsing logic for commas and braces
planetis-m Feb 7, 2026
2a19b39
Merge branch 'devel' into patch-34
planetis-m Feb 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 12 additions & 4 deletions lib/pure/json.nim
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -913,8 +913,12 @@ proc parseJson(p: var JsonParser; rawIntegers, rawFloats: bool, depth = 0): Json
eat(p, tkColon)
var val = parseJson(p, rawIntegers, rawFloats, depth+1)
result[key] = val
if p.tok != tkComma: break
discard getTok(p)
if p.tok == tkComma:
discard getTok(p)
if p.tok == tkCurlyRi:
raiseParseErr(p, "string literal as key")
elif p.tok != tkCurlyRi:
raiseParseErr(p, "'}' or ','")
eat(p, tkCurlyRi)
of tkBracketLe:
if depth > DepthLimit:
Expand All @@ -923,8 +927,12 @@ proc parseJson(p: var JsonParser; rawIntegers, rawFloats: bool, depth = 0): Json
discard getTok(p)
while p.tok != tkBracketRi:
result.add(parseJson(p, rawIntegers, rawFloats, depth+1))
if p.tok != tkComma: break
discard getTok(p)
if p.tok == tkComma:
discard getTok(p)
if p.tok == tkBracketRi:
raiseParseErr(p, "array element")
elif p.tok != tkBracketRi:
raiseParseErr(p, "']' or ','")
eat(p, tkBracketRi)
of tkError, tkCurlyRi, tkBracketRi, tkColon, tkComma, tkEof:
raiseParseErr(p, "{")
Expand Down