Fetch only tags within the range#1349
Merged
jmgomez merged 1 commit intonim-lang:masterfrom Feb 25, 2025
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR restricts the fetched
maxTaggedVersionsto those that match the constraints defined in the Nimble file.Explanation:
When installing, Nimble retrieves the
maxTaggedVersions(default: 4) tags from each dependency, but it does not consider the version constraints specified in the Nimble file. For example, consider the repository: : https://github.com/codex-storage/nim-ethers.When we attempt to install the dependencies using the following command:
The installation process ends with an error:
Error: Downloaded package's version does not satisfy requested version range: wanted >= 0.5.4 & < 0.6.0 got 0.6.2..This error occurs because one of our dependencies, contractabi requires "nimcrypto >= 0.5.4 & < 0.6.0" for version 0.5.0, which is one of our last four tags.
The issue is that
contractabiversion 0.5.0 should not be retrieved, as it does not match our new requirement innim-ethers:"contractabi >= 0.7.0 & < 0.8.0".This PR addresses this issue by retrieving the last
maxTaggedVersionsonly if they match the specified version constraints.Note: Our current workaround is to set
maxTaggedVersionsto 2.