feat(#1450): add --skipBin to limit compilation of hybrid deps#1647
Open
daylinmorgan wants to merge 5 commits intonim-lang:masterfrom
Open
feat(#1450): add --skipBin to limit compilation of hybrid deps#1647daylinmorgan wants to merge 5 commits intonim-lang:masterfrom
daylinmorgan wants to merge 5 commits intonim-lang:masterfrom
Conversation
Collaborator
IMO when Wether to approve this or not, it isnt my call. cc @Araq @arnetheduck |
Contributor
Author
I agree, this make more sense, and is certainly how I would imagine users would expect it to work. |
unrelated test failures were triggered by a missing nim to execute nimscript to downgrade a removed package
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This implements a new flag
--skipBin, so that we can runnimble build|setup|installwithout also compiling hybrid dependencies.In the current implementation, subsequent runs don't attempt to compile the binary for example:
nimble setup --skipBin && nimble setupdoesn't result in hybrid dep binaries being compiled.I'm not sure if that is what we want, let me know if any invocation without
--skipBinshould result in compilation of the hybrid deps. In which case I think I need to adjust the heuristics insolveLockFileDeps.Closes #1450