Open
Conversation
niks3089
reviewed
May 17, 2021
Contributor
|
I'd need more information to understand this PR, will ping you. |
jthomas
reviewed
May 19, 2021
jthomas
reviewed
May 19, 2021
jthomas
reviewed
May 19, 2021
jthomas
suggested changes
May 19, 2021
Contributor
jthomas
left a comment
jthomas
left a comment
There was a problem hiding this comment.
const all the vars please :)
jthomas
suggested changes
May 25, 2021
Contributor
jthomas
left a comment
jthomas
left a comment
There was a problem hiding this comment.
Looking good just one final thing to fix!
jthomas
approved these changes
Jun 30, 2021
Contributor
|
Any comments before merging @rabbah? |
Contributor
|
Will review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implementing API for redisqlite.