[#48] [Part-1] As a developer, I can request permission in Compose#63
Open
thawzintoe-ptut wants to merge 2 commits intodevelopfrom
Open
[#48] [Part-1] As a developer, I can request permission in Compose#63thawzintoe-ptut wants to merge 2 commits intodevelopfrom
thawzintoe-ptut wants to merge 2 commits intodevelopfrom
Conversation
Kover report for Android Common Extensions🧛 Android Common Extensions Unit Tests Code Coverage:
|
| File | Coverage |
|---|---|
PermissionExt.kt |
13.46% |
Modified Files Not Found In Coverage Report:
PermissionExtTest.kt
build.gradle.kts
libs.versions.toml
Codebase cunningly covered by count Shroud 🧛
Generated by 🚫 Danger
Contributor
|
Hi @thawzintoe-ptut 👋 , IMHO, it would be nice to place the implementation under package |
Collaborator
hoangnguyen92dn
left a comment
There was a problem hiding this comment.
@thawzintoe-ptut Please add sample usage of permission in :app model, if the code changes requires adding a lot of file changes, you could open part 2 instead.
common-ktx/src/main/java/co/nimblehq/common/extensions/PermissionExt.kt
Outdated
Show resolved
Hide resolved
common-ktx/src/main/java/co/nimblehq/common/extensions/PermissionExt.kt
Outdated
Show resolved
Hide resolved
common-ktx/src/test/java/co/nimblehq/common/extensions/PermissionExtTest.kt
Show resolved
Hide resolved
thawzintoe-ptut
added a commit
that referenced
this pull request
Mar 19, 2026
07638db to
65d0c97
Compare
65d0c97 to
fbbd521
Compare
Author
|
updated fbbd521. FYI: I will create part-2 for simple usage permission. 🙏 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#48
What happened 👀
This PR adds Jetpack Compose support to the library and introduces permission handling utilities for Compose apps.
Changes:
PermissionExt.ktwith three main utilities:PermissionsHandler- Data class to manage permission staterememberPermissionHandler()- Composable to handle single permissionsHandlePermissionsRequest()- Composable wrapper for permission flowsPermissionsHandlerdata classInsight 📝
Why this approach:
The permission utilities wrap Accompanist's permission APIs with a cleaner interface. The key addition is permanent denial detection - tracking when users select "Don't ask again" on Android. This state isn't directly provided by the system, so we track the transition from showing rationale to not showing rationale while the permission remains denied.
Implementation details:
rememberPermanentDenialTracking()usesrememberSaveableto persist state across configuration changes and detects the rationale → no rationale transitionPermissionsHandleris an@Immutabledata class for predictable Compose recompositionopenSettingsfunction uses the existinggetAppSettingsIntent()extension fromContextExt.ktRelated:
Proof Of Work 📹
Note
I didn't add POC codes in this PR.
Screen_recording_20260113_094931.webm