[#603] Refactor to use Material3 by kaungkhantsoe · Pull Request #605 · nimblehq/android-templates

kaungkhantsoe · 2025-02-27T07:27:17Z

#603

What happened 👀

Refactor to use material 3 for both Template and Sample Compose

Insight 📝

N/A

Proof Of Work 📹

Both Template Compose and Sample Compose run the same

Screen_recording_20250228_143025.mp4

Screen_recording_20250228_143247.mp4

coderabbitai · 2025-02-27T07:27:24Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

github-actions · 2025-02-27T07:32:10Z

	7 Warnings
⚠️	Uh oh! HomeScreen.kt is under 95% coverage!
⚠️	Uh oh! Theme.kt is under 95% coverage!
⚠️	Uh oh! Your project is under 80% coverage!
⚠️	template-compose/gradle/libs.versions.toml#L10 - A newer version of androidx.compose:compose-bom than 2025.02.00 is available: 2025.03.00
⚠️	template-compose/gradle/libs.versions.toml#L12 - A newer version of androidx.navigation:navigation-compose than 2.5.3 is available: 2.8.9
⚠️	template-compose/gradle/libs.versions.toml#L16 - A newer version of com.android.application than 8.8.2 is available: 8.9.0
⚠️	template-compose/gradle/libs.versions.toml#L16 - A newer version of com.android.library than 8.8.2 is available: 8.9.0

Kover report for template-compose:

🧛 Template - Compose Unit Tests Code Coverage: `62.12%`

Coverage of Modified Files:

File	Coverage
`AppColors.kt`	`100.00%`
`AppShapes.kt`	`100.00%`
`AppTypography.kt`	`100.00%`
`HomeScreen.kt`	`67.89%`
`Theme.kt`	`46.43%`

Modified Files Not Found In Coverage Report:

AppBar.kt
Item.kt
ItemList.kt
SecondScreen.kt
ThirdScreen.kt
libs.versions.toml
libs.versions.toml

Codebase cunningly covered by count Shroud 🧛

Generated by 🚫 Danger

Copilot

Pull Request Overview

This PR upgrades both Template and Sample Compose projects to use Material3 by updating dependencies, refactoring theme definitions, and replacing Material imports/usages with their Material3 equivalents.

Swap out androidx.compose.material for androidx.compose.material3 dependencies and imports
Introduce AppColors, AppShapes, AppTypography interfaces backed by Material3 types
Update UI components (e.g., Text, Scaffold, Divider, AppBar) to use Material3 variants

Reviewed Changes

Copilot reviewed 17 out of 17 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
template-compose/gradle/libs.versions.toml	Replaced `compose-material` with `compose-material3` dependency
template-compose/app/src/main/java/.../ui/theme/Theme.kt	Refactored theme entrypoint to use Material3 `MaterialTheme` and new `App*` locals
template-compose/app/src/.../ui/theme/AppColors.kt	Switched `AppColors` to wrap `ColorScheme`, introduced `darkColorScheme`/`lightColorScheme`
sample-compose/gradle/libs.versions.toml	Replaced `compose-material` with `compose-material3` dependency
sample-compose/app/src/main/java/.../AppBar.kt	Updated `TopAppBar` to Material3 and adjusted coloring logic

Comments suppressed due to low confidence (1)

sample-compose/app/src/main/java/co/nimblehq/sample/compose/ui/common/AppBar.kt:25

TopAppBarColors is not a data class and does not have a copy method. Use TopAppBarDefaults.topAppBarColors(containerColor = AppTheme.colors.topAppBarBackground) instead to set the container color.

colors = TopAppBarDefaults.topAppBarColors().copy(

Copilot · 2025-05-23T03:10:48Z

template-compose/app/src/main/java/co/nimblehq/template/compose/ui/theme/Theme.kt

    }
-    val typography = LocalAppTypography.current
-    val shapes = LocalAppShapes.current
+    colors.run {


Mutating the shared AppColors instance via colors.run { this.colorScheme = ... } can introduce unintended side effects across compositions. Consider creating a fresh immutable AppColors object per theme or passing a new instance into CompositionLocalProvider instead of mutating the existing one.

chornerman · 2025-05-27T05:51:54Z

sample-compose/app/src/main/java/co/nimblehq/sample/compose/ui/screens/main/home/Item.kt

+                text = { Text(stringResource(id = R.string.third_edit_menu_title)) },
+                onClick = { onLongClick(uiModel) }
+            )
+


Redundant line

kaungkhantsoe added the type : chore label Feb 27, 2025

kaungkhantsoe added this to the 3.32.0 milestone Feb 27, 2025

kaungkhantsoe self-assigned this Feb 27, 2025

kaungkhantsoe had a problem deploying to template-compose February 27, 2025 07:27 — with GitHub Actions Error

kaungkhantsoe temporarily deployed to template-compose February 27, 2025 07:27 — with GitHub Actions Inactive

kaungkhantsoe had a problem deploying to template-compose February 28, 2025 07:33 — with GitHub Actions Error

kaungkhantsoe marked this pull request as ready for review February 28, 2025 07:34

kaungkhantsoe requested review from AVI5HEK, Johnsonmaung, RkNaing, chornerman, eeeeaa, hoangnguyen92dn, luongvo, manh-t, minhnimble, ryan-conway, sleepylee, thawzintoe-ptut, toby-thanathip and win-than-htike as code owners February 28, 2025 07:34

kaungkhantsoe temporarily deployed to template-compose February 28, 2025 07:35 — with GitHub Actions Inactive

kaungkhantsoe force-pushed the chore/602-update-outdated-dependency-versions branch from 7254956 to d91fffa Compare March 11, 2025 07:19

[#603] Refactor to use Material3

ce96d87

kaungkhantsoe force-pushed the chore/603-update-to-use-material-3-library-instead-of-old-material-library branch from e4bc1db to ce96d87 Compare March 11, 2025 07:20

kaungkhantsoe temporarily deployed to template-compose March 11, 2025 07:20 — with GitHub Actions Inactive

Base automatically changed from chore/602-update-outdated-dependency-versions to develop March 13, 2025 02:59

ryan-conway temporarily deployed to template-compose March 13, 2025 02:59 — with GitHub Actions Inactive

thawzintoe-ptut approved these changes May 22, 2025

View reviewed changes

ryan-conway requested a review from Copilot May 23, 2025 03:08

Copilot AI reviewed May 23, 2025

View reviewed changes

chornerman approved these changes May 27, 2025

View reviewed changes

ryan-conway approved these changes Jun 6, 2025

View reviewed changes

ryan-conway merged commit e64e201 into develop Jun 6, 2025
5 checks passed

ryan-conway deleted the chore/603-update-to-use-material-3-library-instead-of-old-material-library branch June 6, 2025 03:41

github-actions bot mentioned this pull request Jan 30, 2026

Release - 3.32.0 #623

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[#603] Refactor to use Material3#605

[#603] Refactor to use Material3#605
ryan-conway merged 1 commit intodevelopfrom
chore/603-update-to-use-material-3-library-instead-of-old-material-library

kaungkhantsoe commented Feb 27, 2025 •

edited

Loading

Uh oh!

coderabbitai bot commented Feb 27, 2025 •

edited

Loading

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

github-actions bot commented Feb 27, 2025 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI May 23, 2025

Uh oh!

chornerman May 27, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

kaungkhantsoe commented Feb 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What happened 👀

Insight 📝

Proof Of Work 📹

Uh oh!

coderabbitai bot commented Feb 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

github-actions bot commented Feb 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Kover report for template-compose:

🧛 Template - Compose Unit Tests Code Coverage: 62.12%

Coverage of Modified Files:

Modified Files Not Found In Coverage Report:

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Copilot AI May 23, 2025

Choose a reason for hiding this comment

Uh oh!

chornerman May 27, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

kaungkhantsoe commented Feb 27, 2025 •

edited

Loading

coderabbitai bot commented Feb 27, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

github-actions bot commented Feb 27, 2025 •

edited

Loading

🧛 Template - Compose Unit Tests Code Coverage: `62.12%`