[#606] Fix: Incorrect imports in HomeScreenTest and MockUtil in Sample Compose androidTest#607
Merged
hoangnguyen92dn merged 3 commits intodevelopfrom Jan 22, 2026
Conversation
kaungkhantsoe
had a problem deploying
to
template-compose
GitHub Actions
Failure
📝 WalkthroughWalkthroughThis PR updates test dependencies, version catalog entries, fixes import paths to reflect package restructuring, and removes experimental Kotlin Coroutines API annotations from test files. Additionally, packaging configuration is updated with resource merges for license files. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related issues
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
kaungkhantsoe
changed the title
kaungkhantsoe
had a problem deploying
to
template-compose
GitHub Actions
Failure
kaungkhantsoe
had a problem deploying
to
template-compose
GitHub Actions
Failure
kaungkhantsoe
had a problem deploying
to
template-compose
GitHub Actions
Failure
kaungkhantsoe
had a problem deploying
to
template-compose
GitHub Actions
Failure
kaungkhantsoe
had a problem deploying
to
template-compose
GitHub Actions
Failure
kaungkhantsoe
had a problem deploying
to
template-compose
GitHub Actions
Failure
kaungkhantsoe
force-pushed
the
chore/603-update-to-use-material-3-library-instead-of-old-material-library
branch
from
e4bc1db to
ce96d87
Compare
kaungkhantsoe
force-pushed
the
bug/606-fix-incorrect-imports-in-homescreentest-and-mockutil
branch
from
0553ea8 to
55e73e6
Compare
kaungkhantsoe
temporarily deployed
to
template-compose
GitHub Actions
Inactive
Kover report for template-compose:🧛 Template - Compose Unit Tests Code Coverage:
|
| File | Coverage |
|---|
Modified Files Not Found In Coverage Report:
HomeScreenTest.kt
HomeScreenTest.kt
IsFirstTimeLaunchPreferencesUseCaseTest.kt
MockUtil.kt
UpdateFirstTimeLaunchPreferencesUseCaseTest.kt
build.gradle.kts
libs.versions.toml
libs.versions.toml
Codebase cunningly covered by count Shroud 🧛
Generated by 🚫 Danger
kaungkhantsoe
requested review from
AVI5HEK,
Johnsonmaung,
RkNaing,
chornerman,
eeeeaa,
hoangnguyen92dn,
luongvo,
manh-t,
minhnimble and
ryan-conway
as code owners
kaungkhantsoe
requested review from
sleepylee,
thawzintoe-ptut,
toby-thanathip and
win-than-htike
as code owners
chornerman
approved these changes
Mar 11, 2025
There was a problem hiding this comment.
Pull Request Overview
This PR fixes incorrect import paths in HomeScreenTest and MockUtil and updates dependency versions/configurations to resolve test failures and ensure proper UI test setup.
- Corrects import paths for use cases in androidTest.
- Updates dependency versions including mockk, test rules, and test-compose-ui.
- Adjusts packaging configuration for merging license files.
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| sample-compose/gradle/libs.versions.toml | Upgraded dependency versions and added test-mockk-android and test-compose-ui-manifest entries. |
| sample-compose/domain/src/test/java/co/nimblehq/sample/compose/domain/usecases/UpdateFirstTimeLaunchPreferencesUseCaseTest.kt | Removed unused experimental coroutine and assert imports. |
| sample-compose/domain/src/test/java/co/nimblehq/sample/compose/domain/usecases/IsFirstTimeLaunchPreferencesUseCaseTest.kt | Removed unused experimental coroutine and assert imports. |
| sample-compose/app/src/test/java/co/nimblehq/sample/compose/ui/screens/main/home/HomeScreenTest.kt | Removed redundant testing imports. |
| sample-compose/app/src/androidTest/java/co/nimblehq/sample/compose/ui/screens/main/home/HomeScreenTest.kt | Updated usecase import paths to the correct package. |
| sample-compose/app/src/androidTest/java/co/nimblehq/sample/compose/test/MockUtil.kt | Corrected import path from domain.model.Model to domain.models.Model. |
| sample-compose/app/build.gradle.kts | Modified packaging block and updated testing dependency configurations to align with UI test requirements. |
ryan-conway
reviewed
Jun 6, 2025
Collaborator
There was a problem hiding this comment.
These tests fail to run on my end, not sure if it's an existing issue though 🤔
Contributor
Author
There was a problem hiding this comment.
@ryan-conway It passed on my side. Not sure if anyone failed to run 🙏
Screen.Recording.mp4
Contributor
There was a problem hiding this comment.
Confirmed the test passed on my side
There was a problem hiding this comment.
Was it this error?
Execution failed for task ':domain:compileKotlin'.
> Inconsistent JVM-target compatibility detected for tasks 'compileJava' (17) and 'compileKotlin' (21).
I need to set target for kotlin in domain module for the test to run, else it defaults to JVM 21 causing mismatch
Base automatically changed from
chore/603-update-to-use-material-3-library-instead-of-old-material-library
to
develop
June 6, 2025 03:41
ryan-conway
temporarily deployed
to
template-compose
GitHub Actions
Inactive
thawzintoe-ptut
approved these changes
Dec 1, 2025
Contributor
There was a problem hiding this comment.
Confirmed the test passed on my side
eeeeaa
approved these changes
Jan 14, 2026
eeeeaa
left a comment
eeeeaa
left a comment
There was a problem hiding this comment.
Test passed, aside from existing comments, LGTM
RkNaing
approved these changes
Jan 14, 2026
hoangnguyen92dn
changed the title
hoangnguyen92dn
temporarily deployed
to
template-compose
GitHub Actions
Inactive
kaungkhantsoe
had a problem deploying
to
template-compose
GitHub Actions
Error
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@sample-compose/gradle/libs.versions.toml`:
- Line 35: Update the testRules version entry in libs.versions.toml: replace the
current testRules = "1.7.0-alpha01" value with the stable release testRules =
"1.7.0" so the project uses androidx.test:rules 1.7.0 instead of the alpha
build.
| security = "1.0.0" | ||
| testCore = "1.6.1" | ||
| testRules = "1.6.1" | ||
| testRules = "1.7.0-alpha01" |
There was a problem hiding this comment.
🧩 Analysis chain
🌐 Web query:
androidx.test:rules 1.7.0 stable release date
💡 Result:
androidx.test:rules 1.7.0 (stable) was released July 30, 2025. [1][2]
Sources:
[1] Android Developers — Test release notes (Rules 1.7.0).
[2] Android Developers — Recent release notes / All-channel listing.
Update testRules from alpha to stable version.
A stable version of androidx.test:rules 1.7.0 is available (released July 2025). Replace testRules = "1.7.0-alpha01" with testRules = "1.7.0" to use the stable release instead of the alpha version.
🤖 Prompt for AI Agents
In `@sample-compose/gradle/libs.versions.toml` at line 35, Update the testRules
version entry in libs.versions.toml: replace the current testRules =
"1.7.0-alpha01" value with the stable release testRules = "1.7.0" so the project
uses androidx.test:rules 1.7.0 instead of the alpha build.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| lifecycle = "2.8.7" | ||
| mockk = "1.13.5" | ||
| mockk = "1.13.8" | ||
| moshi = "1.15.1" |
There was a problem hiding this comment.
| A newer version of androidx.lifecycle:lifecycle-runtime-compose than 2.8.7 is available: 2.10.0 |
| lifecycle = "2.8.7" | ||
| mockk = "1.13.5" | ||
| mockk = "1.13.8" | ||
| moshi = "1.15.1" |
There was a problem hiding this comment.
| A newer version of androidx.lifecycle:lifecycle-runtime-ktx than 2.8.7 is available: 2.10.0 |
hoangnguyen92dn
deleted the
bug/606-fix-incorrect-imports-in-homescreentest-and-mockutil
branch
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#606
What happened 👀
HomeScreenTestandMockUtil/META-INF/LICENSE.mdand/META-INF/LICENSE-notice.mdInsight 📝
mockk-androidfor UI Test. RefdebugImplementation(libs.test.compose.ui.manifest)forandroidTestor it will throwUnable to resolve activity for Intent { act=android.intent.action.MAIN cat=[android.intent.category.LAUNCHER]error. ReferenceProof Of Work 📹
ScreenRecording.mp4
Summary by CodeRabbit
Chores
Tests
Refactor
✏️ Tip: You can customize this high-level summary in your review settings.