Skip to content

[#617][Part 3] Migrate to navigation 3 - Sample compose project #628

Closed
eeeeaa wants to merge 6 commits intochore/#617-migrate-to-navigation-3from
chore/#617-migrate-to-navigation-3-part-2
Closed

[#617][Part 3] Migrate to navigation 3 - Sample compose project #628
eeeeaa wants to merge 6 commits intochore/#617-migrate-to-navigation-3from
chore/#617-migrate-to-navigation-3-part-2

Conversation

@eeeeaa
Copy link
Copy Markdown

@eeeeaa eeeeaa commented Feb 16, 2026

#617

What happened 👀

  • Many screens in existing sample compose project are unneeded or have unused parameters, we want to refactor this to be more compact, with the main list screen and a details screen
  • We also want to add additional examples regarding custom deep link implementation

Insight 📝

Reference:

Proof Of Work 📹

TODO

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Feb 16, 2026

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch chore/#617-migrate-to-navigation-3-part-2

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@eeeeaa eeeeaa changed the base branch from develop to chore/#617-migrate-to-navigation-3 February 16, 2026 06:46
@eeeeaa eeeeaa temporarily deployed to template-compose February 16, 2026 06:49 — with GitHub Actions Inactive
@github-actions
Copy link
Copy Markdown

github-actions bot commented Feb 16, 2026

16 Warnings
⚠️ Big PR
⚠️ Uh oh! HomeScreen.kt is under 95% coverage!
⚠️ Uh oh! Your project is under 80% coverage!
⚠️ template-compose/gradle/libs.versions.toml#L10 - A newer version of androidx.compose:compose-bom than 2025.02.00 is available: 2026.02.00
⚠️ template-compose/gradle/libs.versions.toml#L12 - A newer version of androidx.navigation:navigation-compose than 2.5.3 is available: 2.9.7
⚠️ template-compose/gradle/libs.versions.toml#L13 - A newer version of androidx.core:core-ktx than 1.15.0 is available: 1.17.0
⚠️ template-compose/gradle/libs.versions.toml#L14 - A newer version of androidx.datastore:datastore-preferences than 1.1.3 is available: 1.2.0
⚠️ template-compose/gradle/libs.versions.toml#L17 - A newer version of com.android.application than 8.8.2 is available: 9.0.1
⚠️ template-compose/gradle/libs.versions.toml#L17 - A newer version of com.android.library than 8.8.2 is available: 9.0.1
⚠️ template-compose/gradle/libs.versions.toml#L19 - A newer version of androidx.hilt:hilt-navigation-compose than 1.2.0 is available: 1.3.0
⚠️ template-compose/gradle/libs.versions.toml#L25 - A newer version of org.jetbrains.kotlinx:kotlinx-coroutines-core than 1.7.3 is available: 1.10.2
⚠️ template-compose/gradle/libs.versions.toml#L25 - A newer version of org.jetbrains.kotlinx:kotlinx-coroutines-test than 1.7.3 is available: 1.10.2
⚠️ template-compose/gradle/libs.versions.toml#L28 - A newer version of androidx.lifecycle:lifecycle-runtime-compose than 2.8.7 is available: 2.10.0
⚠️ template-compose/gradle/libs.versions.toml#L28 - A newer version of androidx.lifecycle:lifecycle-runtime-ktx than 2.8.7 is available: 2.10.0
⚠️ template-compose/gradle/libs.versions.toml#L35 - A newer version of androidx.security:security-crypto than 1.0.0 is available: 1.1.0
⚠️ template-compose/gradle/libs.versions.toml#L36 - A newer version of androidx.test:core-ktx than 1.6.1 is available: 1.7.0

Kover report for template-compose:

🧛 Template - Compose Unit Tests Code Coverage: 73.20%

Coverage of Modified Files:

File Coverage
HomeScreen.kt 92.00%
HomeViewModel.kt 100.00%
RepositoryImpl.kt 100.00%
Response.kt 100.00%

Modified Files Not Found In Coverage Report:

AndroidManifest.xml
AnnotatedStringUtil.kt
ApiService.kt
AppBar.kt
ComposableUtil.kt
Constants.kt
DeepLinkPattern.kt
DetailsScreen.kt
DetailsViewModel.kt
GetDetailsUseCase.kt
GetDetailsUseCaseTest.kt
Item.kt
ItemList.kt
LoginOrRegisterScreen.kt
LoginScreen.kt
MainActivity.kt
MainActivityModule.kt
Repository.kt
SearchScreen.kt
SearchUserUseCase.kt
SearchUserUseCaseTest.kt
libs.versions.toml
strings.xml

Codebase cunningly covered by count Shroud 🧛

Generated by 🚫 Danger

@eeeeaa eeeeaa force-pushed the chore/#617-migrate-to-navigation-3-part-2 branch from 23d5e0e to 66e555f Compare February 19, 2026 04:05
@eeeeaa eeeeaa temporarily deployed to template-compose February 19, 2026 04:05 — with GitHub Actions Inactive
@eeeeaa eeeeaa force-pushed the chore/#617-migrate-to-navigation-3-part-2 branch from 66e555f to 69110df Compare February 19, 2026 07:04
@eeeeaa eeeeaa temporarily deployed to template-compose February 19, 2026 07:04 — with GitHub Actions Inactive
@eeeeaa eeeeaa force-pushed the chore/#617-migrate-to-navigation-3 branch from e995ee4 to 8d0ceae Compare February 19, 2026 07:28
@eeeeaa eeeeaa force-pushed the chore/#617-migrate-to-navigation-3-part-2 branch from 69110df to f0accc9 Compare February 19, 2026 08:22
@eeeeaa eeeeaa temporarily deployed to template-compose February 19, 2026 08:22 — with GitHub Actions Inactive
@eeeeaa eeeeaa force-pushed the chore/#617-migrate-to-navigation-3-part-2 branch from f0accc9 to 699ee5c Compare February 19, 2026 09:00
@eeeeaa eeeeaa temporarily deployed to template-compose February 19, 2026 09:00 — with GitHub Actions Inactive
@eeeeaa eeeeaa force-pushed the chore/#617-migrate-to-navigation-3-part-2 branch from 699ee5c to f49138c Compare February 19, 2026 09:08
@eeeeaa eeeeaa temporarily deployed to template-compose February 19, 2026 09:08 — with GitHub Actions Inactive
@eeeeaa eeeeaa force-pushed the chore/#617-migrate-to-navigation-3-part-2 branch from f49138c to 0c47ace Compare February 19, 2026 09:22
@eeeeaa eeeeaa temporarily deployed to template-compose February 19, 2026 09:22 — with GitHub Actions Inactive
@eeeeaa eeeeaa temporarily deployed to template-compose February 20, 2026 03:49 — with GitHub Actions Inactive
@eeeeaa eeeeaa force-pushed the chore/#617-migrate-to-navigation-3 branch 2 times, most recently from aba7ac7 to 7492383 Compare February 26, 2026 07:52
@eeeeaa eeeeaa changed the title [#617][Part 2] Migrate to navigation 3 - Sample compose project [#617][Part 1.2] Migrate to navigation 3 - Sample compose project Feb 26, 2026
@eeeeaa eeeeaa force-pushed the chore/#617-migrate-to-navigation-3 branch from 2d22049 to 62a16de Compare February 27, 2026 02:27
@eeeeaa eeeeaa changed the title [#617][Part 1.2] Migrate to navigation 3 - Sample compose project [#617][Part 3] Migrate to navigation 3 - Sample compose project Feb 27, 2026
@eeeeaa eeeeaa force-pushed the chore/#617-migrate-to-navigation-3 branch from 62a16de to fad04a9 Compare February 27, 2026 08:10
@eeeeaa
Copy link
Copy Markdown
Author

eeeeaa commented Feb 27, 2026

I will rename and re-open this refactoring 🙏

@eeeeaa eeeeaa closed this Feb 27, 2026
@eeeeaa eeeeaa deleted the chore/#617-migrate-to-navigation-3-part-2 branch February 27, 2026 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant