Conversation
danimoh
left a comment
There was a problem hiding this comment.
👍
What changes did you have in mind for the file structure?
I think the source file structure doesn't have to change.
In dist, the module files could be moved out of their sub folders directly into dist after building.
Or do you even want to move the dist files directly into the packages root?
We could do this with a npm script that moves the files up, builds the package, then removes the files.
|
Yes, I would like to build the package in a way that does not include the |
|
However, maybe this can simply be achieved by instead of packaging the |
bdabadc to
d3e8659
Compare
|
Additionally to the removal of the |
87a7d3f to
4c0a28d
Compare
664c9e1 to
63c3698
Compare
Convert all classes with only static methods into tree-shakable ES6 modules (as explained in #29 (comment)). Utilities can now be directly accessed as
which only bundles
isSafariand tree-shakes all other methods, that were previously included (and thus bundled) in theBrowserDetectionclass.(Changing the import path is a topic for another PR, because it would likely change the whole file structure.)
This change is backwards-compatible, as the
main.jsstill exports whole namespaces with the original names. Please check if you agree.The diff should be watched with whitespace turned off, since the indentation got reduced by one level.