Skip to content

add destinations #308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
olknegate merged 1 commit into from
Nov 14, 2025
Merged

add destinations #308

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion create/serviceconnection.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -213,7 +213,7 @@ func groupVersionKindFromKind(kind string) (schema.GroupVersionKind, error) {
func ServiceConnectionKongVars() kong.Vars {
result := make(kong.Vars)
result["allowed_sources"] = "kubernetescluster, application"
result["allowed_destinations"] = "keyvaluestore"
result["allowed_destinations"] = "keyvaluestore, mysql, postgres"
result["label_selector_placeholder"] = "'key1=value1,key2=value2,key3 in (value3)'"
result["label_selector_usage"] = "Selector (label query) to filter on, supports '=', '==', '!=', 'in', 'notin'. Matching objects must satisfy all of the specified label constraints."
result["label_selector_requirements"] = "Can only be set when the source is a KubernetesCluster."
Expand Down
12 changes: 6 additions & 6 deletions create/serviceconnection_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ func TestServiceConnection(t *testing.T) {
SourceNamespace: "application-ns",
},
source: "application/test-application",
destination: "keyvaluestore/test-kvs",
destination: "mysql/test-mysql",
want: networking.ServiceConnectionParameters{
Source: networking.Source{
Reference: meta.TypedReference{
Expand All @@ -87,12 +87,12 @@ func TestServiceConnection(t *testing.T) {
},
Destination: meta.TypedReference{
Reference: meta.Reference{
Name: "test-kvs",
Name: "test-mysql",
Namespace: "default",
},
GroupKind: metav1.GroupKind{
Group: storage.Group,
Kind: storage.KeyValueStoreKind,
Kind: storage.MySQLKind,
},
},
},
Expand Down Expand Up @@ -140,7 +140,7 @@ func TestServiceConnection(t *testing.T) {
},
},
source: "kubernetescluster/test-cluster",
destination: "keyvaluestore/test-kvs",
destination: "postgres/test-postgres",
want: networking.ServiceConnectionParameters{
Source: networking.Source{
Reference: meta.TypedReference{
Expand Down Expand Up @@ -190,12 +190,12 @@ func TestServiceConnection(t *testing.T) {
},
Destination: meta.TypedReference{
Reference: meta.Reference{
Name: "test-kvs",
Name: "test-postgres",
Namespace: "default",
},
GroupKind: metav1.GroupKind{
Group: storage.Group,
Kind: storage.KeyValueStoreKind,
Kind: storage.PostgresKind,
},
},
},
Expand Down