Dep file parser seperator char#2602
Open
moritzx22 wants to merge 3 commits intoninja-build:masterfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
The parser for the dependency files does not check the separation character between variable names.
Here an example:
foo.o: fo;o.cthis is parsed successfully by the parser and has the same result as:
foo.o: fo o.cThe ";" can be replaced with other characters, that are not considered valid characters as part of a variable name. Same effect.
see issues/2599. This issue is silently ignored.
Proposal
check the separation character to be part of a white list.
In this proposal it is suggested to be whitespaces [\t\v\f ] (to be checked).
the dep file
foo.o: fo;o.cwould case an error to ninja and would stop.
Performance
Some checks with the performance tool showed no significant changes.
to think about
The syntax will change for the deps file. I am just assuming that this is not a feature to have no checks for the separation character...