Fix stale progress counters for console/restat edges (#1336, #2507)

[jkammerland]

This PR fixes two progress-reporting issues in Ninja where [current/total] could be incorrect:

1. Console edge completion in dumb TTY ("Installing files" step always numbered one too low on stdout (i.e. step [N/N] never shown) #1336):
   final console steps (for example install) could show [N-1/N] and never reach [N/N].
2. Stale denominator after restat/generator pruning (globbing in cmake with ninja, incomplete status log #2507):
   progress could start with an old total (for example [1/14]) and then “jump down” (for example [2/6]) once pruned edges were removed from the plan.

The fixes are limited to status/progress reporting behavior and regression coverage. I have tested on linux and windows, for multiple of my non-trivial repos with code generation involved. I used llms (codex) to help me implement this.

Problem details

#1336 (console edge in dumb TTY)

In non-smart TTY mode, console edges were shown at start, but completion reporting did not consistently advance %f/%t to the final count.
That produced output like:

[1/5] ...
[2/5] ...
[3/5] ...
[4/5] ...
[4/5] Installing files.

#2507 (restat/generator pruning)

Status printing happened before plan finalization (plan_.EdgeFinished()), so %t could be computed from a stale pre-prune total for one print.
That produced patterns like:

[1/14] Running gentest_codegen ...
[2/6] Building ...

or no-op glob checks like:

[0/2] Re-checking globbed directories...
ninja: no work to do.

What changed

1) Status policy cleanup for console vs non-console edges (src/status_printer.cc)

• Added small helper predicates to make start/finish print policy explicit.
• In dumb TTY, completion status for console edges is printed on final edge so progress can reach [N/N].
• Preserves existing interrupted/failure behavior and handles NINJA_STATUS="" correctly (no extra completion-only status line).

2) Finalize plan before printing completion (src/build.cc, src/build.h)

• Introduced helper FinalizeEdgeAndReportStatus(...).
• Calls plan_.EdgeFinished(...) before status_->BuildEdgeFinished(...).
• Ensures status formatter sees post-prune totals for restat / generator+restat flows.

3) Regression tests (misc/output_test.py)

Added/updated tests for:

• "Installing files" step always numbered one too low on stdout (i.e. step [N/N] never shown) #1336 non-TTY + dumb-TTY + failure + interrupt + empty NINJA_STATUS.
• Restat pruning denominator correctness.
• Generator+restat pruning denominator correctness.

Before / after examples

Install-style console final edge (#1336)

Before:

[4/5] Installing files.

After:

[5/5] Installing files.

Globbing/no-op check (#2507)

Before:

[0/2] Re-checking globbed directories...
ninja: no work to do.

After:

[1/1] Re-checking globbed directories...
ninja: no work to do.

Codegen + prune

Before:

[1/14] Running gentest_codegen ...
[2/6] Building ...

After:

[1/3] Running gentest_codegen ...
[2/3] Building ...
[3/3] Linking ...

Scope / risk statement

This change is intended to affect status/progress output only:

• %f/%t progress accounting
• when status lines are printed for console edges
• denominator correctness after plan pruning

It should not change actual build decisions, dependency resolution, command execution, or produced artifacts.
The only externally visible behavior change is progress/log line content and timing of those status lines.

[jkammerland]

Here is how you can test that the regression tests I added fail before this patch, and succeed after:

# First checkout my fork!

# from repo root
PRE_FIX=$(git merge-base HEAD origin/master)
WT=.worktrees/pre-fix-progress

git worktree add "$WT" "$PRE_FIX"

# bring current regression tests into pre-fix tree
git show HEAD:misc/output_test.py > "$WT/misc/output_test.py"

# pre-fix run: should FAIL
(
  cd "$WT"
  ./configure.py --bootstrap
  python3 -m pytest -q misc/output_test.py -k \
  "issue_1336_dumb_tty or restat_prunes_progress_total or generator_restat_prunes_progress_total"
)

# current PR run: should PASS
(
  cd .
  ./configure.py --bootstrap
  python3 -m pytest -q misc/output_test.py -k \
  "issue_1336_dumb_tty or restat_prunes_progress_total or generator_restat_prunes_progress_total"
)

# cleanup (comment out if you want)
# git worktree remove --force "$WT"

[jkammerland]

To improve UX further we could also try to mark "phase boundary" to better understand the progress of different steps. E.g

[1/2] Re-checking globbed directories...
[2/2] Re-running CMake...
ninja: regeneration complete...             <---- NEW
[1/1] Re-checking globbed directories...
ninja: manifest check complete...          <---- NEW
[1/2] Building ...
[2/2] Linking ...

But I have not included any such change here, better put that in a new PR after discussion/approval.

I'm also looking a bit at #2709, while I'm at it - but I will make no changes related to that here.