Updated NinjaBlockEthernet Library#2
Open
samgregory wants to merge 1 commit intoninjablocks:masterfrom
samgregory:master
Open
Updated NinjaBlockEthernet Library#2samgregory wants to merge 1 commit intoninjablocks:masterfrom samgregory:master
samgregory wants to merge 1 commit intoninjablocks:masterfrom
samgregory:master
Conversation
…Ticks and to support serialised JSON (required for protocols) sent from the cloud.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have included the changes I made to the NinjaBlockEthernet library that enable the keep alive Tick and support serialised JSON (needed to parse the Light protocol for example). Because serialised JSON results in long strings I had to increase the DATA_SIZE and DATA_LEN constants.
Known issue: Reading from the DATAString on a Tick will fail. You MUST check NinjaBlock.IsTick before trying to read data.
I don't use the NinjaBlockSerial library so it hasn't been updated.