Skip to content

Commit 4f90274

Browse files
authored
Merge pull request #156 from nipreps/fix/update-niworkflows-1.4.0rc4
FIX: Update to new *NiWorkflows* API
2 parents 0844cb6 + c78c3ab commit 4f90274

File tree

5 files changed

+34
-22
lines changed

5 files changed

+34
-22
lines changed

dmriprep/workflows/dwi/base.py

Lines changed: 12 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -68,8 +68,10 @@ def init_dwi_preproc_wf(dwi_file, has_fieldmap=False):
6868
* :py:func:`~dmriprep.workflows.dwi.outputs.init_reportlets_wf`
6969
7070
"""
71+
from niworkflows.interfaces.reportlets.registration import (
72+
SimpleBeforeAfterRPT as SimpleBeforeAfter,
73+
)
7174
from ...interfaces.vectors import CheckGradientTable
72-
from niworkflows.interfaces import SimpleBeforeAfter
7375
from .util import init_dwi_reference_wf
7476
from .outputs import init_reportlets_wf
7577
from .eddy import init_eddy_wf
@@ -219,7 +221,10 @@ def _bold_reg_suffix(fallback):
219221
)
220222

221223
eddy_report = pe.Node(
222-
SimpleBeforeAfter(before_label="Distorted", after_label="Eddy Corrected",),
224+
SimpleBeforeAfter(
225+
before_label="Distorted",
226+
after_label="Eddy Corrected",
227+
),
223228
name="eddy_report",
224229
mem_gb=0.1,
225230
)
@@ -268,7 +273,6 @@ def _bold_reg_suffix(fallback):
268273
# fmt: on
269274
return workflow
270275

271-
from niworkflows.interfaces import SimpleBeforeAfter
272276
from niworkflows.interfaces.utility import KeySelect
273277
from sdcflows.workflows.apply.registration import init_coeff2epi_wf
274278
from sdcflows.workflows.apply.correction import init_unwarp_wf
@@ -279,8 +283,7 @@ def _bold_reg_suffix(fallback):
279283
write_coeff=True,
280284
)
281285
unwarp_wf = init_unwarp_wf(
282-
debug=config.execution.debug,
283-
omp_nthreads=config.nipype.omp_nthreads
286+
debug=config.execution.debug, omp_nthreads=config.nipype.omp_nthreads
284287
)
285288
unwarp_wf.inputs.inputnode.metadata = layout.get_metadata(str(dwi_file))
286289

@@ -297,7 +300,10 @@ def _bold_reg_suffix(fallback):
297300
)
298301

299302
sdc_report = pe.Node(
300-
SimpleBeforeAfter(before_label="Distorted", after_label="Corrected",),
303+
SimpleBeforeAfter(
304+
before_label="Distorted",
305+
after_label="Corrected",
306+
),
301307
name="sdc_report",
302308
mem_gb=0.1,
303309
)

dmriprep/workflows/dwi/outputs.py

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,13 +7,19 @@
77

88
def init_reportlets_wf(output_dir, sdc_report=False, name="reportlets_wf"):
99
"""Set up a battery of datasinks to store reports in the right location."""
10-
from niworkflows.interfaces.masks import SimpleShowMaskRPT
10+
from niworkflows.interfaces.reportlets.masks import SimpleShowMaskRPT
1111

1212
workflow = Workflow(name=name)
1313

1414
inputnode = pe.Node(
1515
niu.IdentityInterface(
16-
fields=["source_file", "dwi_ref", "dwi_mask", "validation_report", "sdc_report"]
16+
fields=[
17+
"source_file",
18+
"dwi_ref",
19+
"dwi_mask",
20+
"validation_report",
21+
"sdc_report",
22+
]
1723
),
1824
name="inputnode",
1925
)

dmriprep/workflows/dwi/util.py

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1,17 +1,7 @@
11
"""Utility workflows for :abbr:`DWI (diffusion weighted imaging)` data."""
2-
32
from nipype.pipeline import engine as pe
43
from nipype.interfaces import utility as niu, fsl, afni
5-
64
from niworkflows.engine.workflows import LiterateWorkflow as Workflow
7-
from niworkflows.interfaces.images import ValidateImage
8-
from niworkflows.interfaces.fixes import (
9-
FixN4BiasFieldCorrection as N4BiasFieldCorrection,
10-
)
11-
from niworkflows.interfaces.nibabel import ApplyMask
12-
from niworkflows.interfaces.utils import CopyXForm
13-
14-
from ...interfaces.images import ExtractB0, RescaleB0
155

166

177
def init_dwi_reference_wf(mem_gb, omp_nthreads, name="dwi_reference_wf"):
@@ -68,6 +58,10 @@ def init_dwi_reference_wf(mem_gb, omp_nthreads, name="dwi_reference_wf"):
6858
* :py:func:`~dmriprep.workflows.dwi.util.init_enhance_and_skullstrip_wf`
6959
7060
"""
61+
from niworkflows.interfaces.header import ValidateImage
62+
63+
from ...interfaces.images import ExtractB0, RescaleB0
64+
7165
workflow = Workflow(name=name)
7266

7367
inputnode = pe.Node(
@@ -185,6 +179,12 @@ def init_enhance_and_skullstrip_dwi_wf(
185179
reportlet for the skull-stripping
186180
187181
"""
182+
from niworkflows.interfaces.header import CopyXForm
183+
from niworkflows.interfaces.fixes import (
184+
FixN4BiasFieldCorrection as N4BiasFieldCorrection,
185+
)
186+
from niworkflows.interfaces.nibabel import ApplyMask
187+
188188
workflow = Workflow(name=name)
189189
inputnode = pe.Node(
190190
niu.IdentityInterface(fields=["in_file", "pre_mask"]), name="inputnode"

docs/requirements.txt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,12 +2,12 @@ git+https://github.com/AleksandarPetrov/napoleon.git@0dc3f28a309ad602be5f44a9049
22
git+https://github.com/rwblair/sphinxcontrib-versioning.git@39b40b0b84bf872fc398feff05344051bbce0f63#egg=sphinxcontrib-versioning
33
nbsphinx
44
nipype ~= 1.5.1
5-
niworkflows >=1.4.0rc0,<1.5
5+
niworkflows >=1.4.0rc5,<1.5
66
packaging
77
pydot>=1.2.3
88
pydotplus
99
sdcflows ~= 2.0.0
10-
smriprep >= 0.8.0rc0
10+
smriprep >= 0.8.0rc2
1111
sphinx >=2.1.2,<3.0
1212
sphinx-argparse
1313
sphinx_rtd_theme

setup.cfg

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,12 +25,12 @@ install_requires =
2525
indexed_gzip >=0.8.8
2626
nibabel ~= 3.0
2727
nipype >= 1.5.1, < 2.0
28-
niworkflows >= 1.4.0rc0, <1.5
28+
niworkflows >= 1.4.0rc5, <1.5
2929
numpy
3030
pybids >= 0.11.1
3131
pyyaml
3232
sdcflows ~= 2.0.0
33-
smriprep >= 0.8.0rc0
33+
smriprep >= 0.8.0rc2
3434
svgutils != 0.3.2
3535
templateflow ~= 0.6
3636
toml

0 commit comments

Comments
 (0)