Skip to content

Conversation

oesteban
Copy link
Member

This PR completes a previous one regarding the diffusion table.

Amends: #100

This PR completes a previous one regarding the diffusion table.

Amends: nipreps#100
@oesteban oesteban requested a review from arokem April 13, 2020 17:05
@pull-assistant
Copy link

Score: 1.00

Best reviewed: commit by commit


Optimal code review plan

     FIX: Revise vector tests broken when addressing other issues

Powered by Pull Assistant. Last update 695c43c ... 695c43c. Read the comment docs.

@codecov
Copy link

codecov bot commented Apr 13, 2020

Codecov Report

Merging #103 into master will increase coverage by 0.86%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #103      +/-   ##
==========================================
+ Coverage   51.06%   51.92%   +0.86%     
==========================================
  Files          21       21              
  Lines        1218     1219       +1     
  Branches      161      161              
==========================================
+ Hits          622      633      +11     
+ Misses        581      574       -7     
+ Partials       15       12       -3     
Impacted Files Coverage Δ
dmriprep/interfaces/vectors.py 100.00% <ø> (ø)
dmriprep/utils/vectors.py 93.33% <100.00%> (+3.08%) ⬆️
dmriprep/workflows/dwi/base.py 46.66% <0.00%> (+16.66%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9d83d50...695c43c. Read the comment docs.

@oesteban oesteban merged commit 9d95e73 into nipreps:master Apr 15, 2020
@oesteban oesteban deleted the fix/doctests-broken branch April 15, 2020 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant