-
Notifications
You must be signed in to change notification settings - Fork 305
ENH: Confound model enhancement #1586
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
57 commits
Select commit
Hold shift + click to select a range
513be36
(#1458) sketch CompCor enhancement
rciric ce35dd6
(#1458) new reportlets for CompCor and confounds
rciric 6abb4da
Merge branch 'master' of https://github.com/poldracklab/fmriprep
rciric ce4d130
jsonise and return CompCor metadata
rciric 64a65ee
jsonise and return CompCor metadata
rciric 0008fb1
add references for expanded model and censoring thresholds
rciric 4d5d614
acompcor metadata to circle
rciric 71ff4dc
add contributor
rciric 6ffe441
tcompcor metadata to circle
rciric ebfa9f9
fix figure legends
rciric 95dcb2a
more descriptive citation
rciric 1e50ae3
run aCompCor for WM, CSF, and combined masks
rciric 22c9e4b
specification of spike thresholds and decomposition output
rciric 3134728
propagate spike and CompCor specs
rciric b99afb0
add CLI options for spikes and CompCor
rciric 5618629
[skip ci] expand description, minor fixes
rciric 3a0d149
[skip ci] conform to updated SpikeRegressors interface
rciric 50b8ce2
Merge remote-tracking branch 'upstream/master' into rciric-patch-1
oesteban 0b32336
pin adequate versions of nipype and niworkflows
oesteban 38d0550
Merge pull request #1 from oesteban/rciric-patch-1
rciric d9c33e9
[skip ci] update documentation to reflect new confounds options
rciric 69a7908
[skip ci] update documentation to reflect new confounds options
rciric ae1d91d
[skip ci] update documentation to reflect new confounds options
rciric b0a7490
use NaN failure mode for empty masks [skip ci]
rciric f5b9e35
sketch confounds metadata sink
rciric caa8a0e
reconcile updates
rciric 04ec5c9
configure circle wf
rciric e1fa3e4
configure circle wf
rciric 9419f00
update circle hash to latest niworkflows branch
rciric 4532698
Merge branch 'master' into master
effigies 834ad54
reconcile updates
rciric 08f23f3
Merge branch 'master' of https://github.com/rciric/fmriprep
rciric 9f1194a
fix(deps): pin correct nipype commit, fix duplicated niworkflows link
oesteban 31188bd
Merge branch 'ds005/fix-master' into rmaster
oesteban 7ad3602
Merge remote-tracking branch 'rciric/verify_unpushed' into pr/1487
oesteban 1038b21
fix(autodocs): remove extra parens in ``.. workflow::`` block of ``in…
oesteban 44708bc
fix(tests): add output missing in partial derivatives index [skip doc…
oesteban 4a7b5ff
update pin for dependencies
rciric 6bebccc
(maint) reconcile with upstream
rciric d16e751
(maint) reconcile with upstream
rciric 59ee4b6
Merge remote-tracking branch 'upstream/master' into pr/1487
oesteban 8fe2f75
Merge branch 'pr/1487' into repin
oesteban 7e24bb6
Merge pull request #3 from rciric/repin
oesteban 28c0823
Merge remote-tracking branch 'upstream/master' into pr/1487
oesteban 6af536b
pin(niworkflows,nipype): update pinnings before merge
oesteban c76a5a1
Merge branch 'pr/1487' of github.com:oesteban/fmriprep into pr/1487
oesteban 3db3156
Merge remote-tracking branch 'upstream/master' into pr/1487
oesteban ea4726a
Merge branch 'enh/new-reports' into pr/1487
oesteban 50c8287
fix(workflow): set correct ``desc`` input to ``DerivativesDataSink``
oesteban b74dddb
Merge remote-tracking branch 'upstream/master' into pr/1487
oesteban 463e237
pin(niworkflows): update to latest poldracklab/niworkflows#357
oesteban 16bebee
Merge remote-tracking branch 'upstream/master' into pr/1487
oesteban 38378e8
Merge remote-tracking branch 'upstream/master' into pr/1487
oesteban 4c22d7f
fix(workflow): address @effigies' comment
oesteban 325c6a9
fix(workflow): missing connections forgotten when resolving conflicts
oesteban 6a62c86
fix(docs): add missing comma after function argument
oesteban b6e090e
Merge remote-tracking branch 'upstream/master' into pr/1487
oesteban File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rciric I feel we will need to expand this and elaborate a bit more about what components were dropped, how they are denoted and why they were dropped. I'd be fine to do that on another PR (with a branch called
docs/<whatever>
we would be saving a lot of CircleCI cycles).