ENH: Add descriptions.tsv for BIDS derivatives#3591
Open
yarikoptic wants to merge 4 commits intonipreps:masterfrom
Open
ENH: Add descriptions.tsv for BIDS derivatives#3591yarikoptic wants to merge 4 commits intonipreps:masterfrom
yarikoptic wants to merge 4 commits intonipreps:masterfrom
Conversation
Generate a descriptions.tsv file documenting the processing procedures associated with each desc- entity value used in fMRIPrep derivatives, following the BIDS common derivatives specification. Key features: - Procedure-focused descriptions explain what processing was performed - Dynamic generation: steps only listed if actually applied (e.g., SDC omitted when no fieldmaps available) - Parameters column captures thresholds and settings used - Covers both data files (preproc, brain, hmc) and report figures 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Update CircleCI expected output files to include the new descriptions.tsv file that documents desc- entity procedures. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
yarikoptic
commented
Dec 21, 2025
fmriprep/tests/test_descriptions.py
Outdated
| from fmriprep.utils.bids import write_descriptions_tsv | ||
|
|
||
|
|
||
| @pytest.mark.ai_generated |
Contributor
Author
There was a problem hiding this comment.
FWIW, this is my convention to annotate AI produced unittests since often they are not "as good" as human curated and might require either consolidation or just more careful review to see if worthy
- Prefix unused unpacked variables with underscore - Split compound assertion into separate assertions - Apply ruff formatting fixes 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #3591 +/- ##
==========================================
+ Coverage 72.88% 73.47% +0.58%
==========================================
Files 60 61 +1
Lines 4821 4984 +163
Branches 626 655 +29
==========================================
+ Hits 3514 3662 +148
- Misses 1164 1171 +7
- Partials 143 151 +8 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
The project uses --strict-markers, so unregistered markers cause errors. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request
This PR adds support for generating a
descriptions.tsvfile at the derivatives root level, following the BIDS common derivatives specification.What it does
fMRIPrep produces outputs with
_desc-entities (e.g.,desc-preproc,desc-brain,desc-hmc) but previously lacked documentation of what these descriptions mean. This PR adds:fmriprep/data/descriptions.json- Template definitions for alldesc-entities with:_suffix)fmriprep/utils/bids.py- Newwrite_descriptions_tsv()function that:parameterscolumn with thresholds and settings usedIntegration in
fmriprep/cli/run.py- Writesdescriptions.tsvalongsidedataset_description.jsonExample output
With full preprocessing (SDC + STC):
Without SDC/STC:
Tests
Documentation that should be reviewed
The
descriptions.tsvoutput format follows BIDS conventions. No documentation changes are included in this PR, but the output files are self-documenting.