Skip to content

Apply Repo-Review rules#3592

Merged
effigies merged 3 commits intonipreps:masterfrom
DimitriPapadopoulos:repo-review
Jan 13, 2026
Merged

Apply Repo-Review rules#3592
effigies merged 3 commits intonipreps:masterfrom
DimitriPapadopoulos:repo-review

Conversation

@DimitriPapadopoulos
Copy link
Contributor

@DimitriPapadopoulos DimitriPapadopoulos commented Jan 12, 2026

Changes proposed in this pull request

  • PC170: Uses PyGrep hooks (only needed if rST present)
  • PC191: Ruff show fixes if fixes enabled
  • PC903: Specified pre-commit CI schedule
  • PP006: The dev dependency group should be defined (it looks like the tox/uv combination cannot support PEP 735 out-of-the-box)

Documentation that should be reviewed

Uses PyGrep hooks (only needed if rST present)
Ruff show fixes if fixes enabled
Specified pre-commit CI schedule
@DimitriPapadopoulos DimitriPapadopoulos marked this pull request as draft January 12, 2026 16:25
@DimitriPapadopoulos DimitriPapadopoulos force-pushed the repo-review branch 5 times, most recently from eef6f89 to 544bbbb Compare January 12, 2026 17:21
@DimitriPapadopoulos DimitriPapadopoulos marked this pull request as ready for review January 12, 2026 17:23
@codecov
Copy link

codecov bot commented Jan 12, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 72.91%. Comparing base (b7077c0) to head (544bbbb).
⚠️ Report is 4 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3592   +/-   ##
=======================================
  Coverage   72.91%   72.91%           
=======================================
  Files          60       60           
  Lines        4821     4821           
  Branches      626      626           
=======================================
  Hits         3515     3515           
- Misses       1164     1166    +2     
+ Partials      142      140    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@effigies
Copy link
Member

Thanks!

@effigies effigies merged commit 37e151d into nipreps:master Jan 13, 2026
18 checks passed
@DimitriPapadopoulos DimitriPapadopoulos deleted the repo-review branch January 13, 2026 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants