Skip to content

Get rid of black#3593

Closed
DimitriPapadopoulos wants to merge 1 commit intonipreps:masterfrom
DimitriPapadopoulos:black
Closed

Get rid of black#3593
DimitriPapadopoulos wants to merge 1 commit intonipreps:masterfrom
DimitriPapadopoulos:black

Conversation

@DimitriPapadopoulos
Copy link
Contributor

Changes proposed in this pull request

We don't use black any more. Explicitly disabling it is confusing, it gives the wrong impression.

Documentation that should be reviewed

We don't use black any more. Explicitly disabling it is confusing,
it gives the wrong impression.
@codecov
Copy link

codecov bot commented Jan 12, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 72.91%. Comparing base (b7077c0) to head (61c50a2).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3593   +/-   ##
=======================================
  Coverage   72.91%   72.91%           
=======================================
  Files          60       60           
  Lines        4821     4821           
  Branches      626      626           
=======================================
  Hits         3515     3515           
  Misses       1164     1164           
  Partials      142      142           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@effigies
Copy link
Member

vscode turned on black by default some years back, and it became common to get PRs with whole files reformatted for minor changes. The purpose this serves is to disable autoformatting from any tool that wants to auto-apply black, which is mostly likely a new contributor and someone who doesn't need their first interaction with the project to be quibbling over formatting. The cost of keeping this in is lower than the cost of removing it, IMO.

@effigies effigies closed this Jan 12, 2026
@DimitriPapadopoulos
Copy link
Contributor Author

This is the only project I know of with such settings. I have not seen other projects complain.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants