[FIX] Sanitize plus signs in from entities in workflow names#3604
Merged
effigies merged 2 commits intonipreps:maint/25.2.xfrom Feb 6, 2026
Merged
[FIX] Sanitize plus signs in from entities in workflow names#3604effigies merged 2 commits intonipreps:maint/25.2.xfrom
effigies merged 2 commits intonipreps:maint/25.2.xfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## maint/25.2.x #3604 +/- ##
================================================
+ Coverage 73.21% 73.29% +0.07%
================================================
Files 60 60
Lines 4838 4856 +18
Branches 628 630 +2
================================================
+ Hits 3542 3559 +17
- Misses 1156 1158 +2
+ Partials 140 139 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Collaborator
Author
|
fixes #3605 |
Collaborator
Author
|
Similar fixes might be required in smriprep or qsiprep. Looks like tox style fails on something unrelated to this PR. |
Contributor
|
LGTM |
Member
|
Looks good. Do you want to target the |
f2b6897 to
2aae654
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request
Sanitize + char , now part of the BIDS spec , for instance in
acqortaskentities.https://bids-specification.readthedocs.io/en/stable/glossary.html#label-formats
Without that fix, any use of + sign results in the following traceback
Documentation that should be reviewed
NA