FIX: Improve FreeSurfer ID predictability#3607
Draft
mgxd wants to merge 8 commits intonipreps:masterfrom
Draft
Conversation
for more information, see https://pre-commit.ci
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3607 +/- ##
==========================================
- Coverage 73.19% 73.18% -0.01%
==========================================
Files 60 60
Lines 4839 4834 -5
Branches 628 629 +1
==========================================
- Hits 3542 3538 -4
+ Misses 1156 1154 -2
- Partials 141 142 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The intent after #3495 was encode as much information on how the anatomical template was formed into the FreeSurfer subject ID, but this introduced problems where the resulting FS ID could not be reused across a few cases:
Starting this draft to think on how to cleanly address this in the future series.
Example 1
Assume we have sub-01 with a single session,
pre:Now if a
postsession was added, thepost's anatomical will be used infirst-lex.IMO, sub-01 is misleading for both
first-lexandunbiased, and only becomes hazier as additional sessions are added. Perhaps instead of changing the ID, some metadata (Sources) can be tied directly to the FreeSurfer subjects dir.Example 2
sub-Z has one
anatand manyfuncXsessions.anatwas processed with--anat-onlyand will be reused via--derivativesSuggestions and additional examples are welcome and appreciated.