-
Notifications
You must be signed in to change notification settings - Fork 133
MAINT: ruff check
#1420
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
DimitriPapadopoulos
wants to merge
14
commits into
nipreps:master
Choose a base branch
from
DimitriPapadopoulos:ruff
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
MAINT: ruff check
#1420
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- No need to specify `F` and `E` rules with `extend-select`. - Update rules to ignore.
E741 Ambiguous variable name: `l`
E401 Multiple imports on one line
W605 Invalid escape sequence
I001 Import block is un-sorted or un-formatted
C408 Unnecessary `dict()` call (rewrite as a literal)
C413 Unnecessary `list()` call around `sorted()`
C414 Unnecessary `list()` call within `sorted()`
C420 Unnecessary dict comprehension for iterable; use `dict.fromkeys` instead
PT001 Use `@pytest.fixture` over `@pytest.fixture()`
UP031 Use format specifiers instead of percent format
UP035 Import from `collections.abc` instead
ICN001 `seaborn` should be imported as `sns`
da59638
to
595401e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ruff check
had been left out from tests.