Skip to content

Conversation

mgxd
Copy link
Collaborator

@mgxd mgxd commented Sep 13, 2024

Builds off #394

Closes #388

This PR addresses a few age parsing related issues:

  • Handle converting floating point age to months.
  • Add support for regex expressions when parsing tsv
    • This helps select age from the first anatomical scan when parsing scans.tsv
  • Warn if multiple rows were indexed from the TSV, and use the first row.
  • Error if age column found but no unit information is given.

@mgxd
Copy link
Collaborator Author

mgxd commented Sep 13, 2024

@erikglee @scott-huberty @lundq163

Please take a look and/or give this branch a try

@mgxd mgxd merged commit d24cd43 into nipreps:master Sep 20, 2024
9 checks passed
@mgxd mgxd deleted the fix/age-parsing branch September 20, 2024 15:10
mgxd added a commit that referenced this pull request Oct 3, 2024
24.1.0 (October 02, 2024)

This new minor release includes a few bug fixes, such as excluding MCRIBS from surface reconstruction without a precomputed segmentation and ensuring generated derivatives are not masked, as well as improvements to reporting.

  * ENH: Add boilerplate, errors to report (#403)
  * ENH: Add age to session report (#402)
  * ENH: Improvements to age parsing (#395, #398)

  * FIX: MCRIBS auto surface reconstruction logic (#399)
  * FIX: Do not force masking of anatomicals when using `--derivatives` (#400)

  * MAINT: Revisit warnings filter (#396)
  * MAINT: Automate testing with tox (#404)
  * MAINT: Port over parser arguments and tests from fmriprep (#401)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Issue finding age in months from participants.tsv for v24.0.0

2 participants