Skip to content

MAINT: Remove deprecated parser arguments #407

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 8, 2024
Merged

MAINT: Remove deprecated parser arguments #407

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 0 additions & 29 deletions nibabies/cli/parser.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,10 +26,6 @@ def _build_parser():

deprecations = {
# parser attribute name: (replacement flag, version slated to be removed in)
'bold2t1w_init': ('--bold2anat-init', '24.2.0'),
'bold2t1w_dof': ('--bold2anat-dof', '24.2.0'),
'force_reconall': ('--surface-recon-method freesurfer', '24.2.0'),
'fs_no_reconall': ('--surface-recon-method none', '24.2.0'),
}

class DeprecatedAction(Action):
Expand Down Expand Up @@ -393,19 +389,6 @@ def _str_none(val):
Useful for further Tedana processing post-NiBabies.""",
)

g_conf.add_argument(
'--bold2t1w-init',
action=DeprecatedAction,
choices=['register', 'header'],
help='Deprecated - use `--bold2anat-init` instead.',
)
g_conf.add_argument(
'--bold2t1w-dof',
action=DeprecatedAction,
choices=[6, 9, 12],
type=int,
help='Deprecated - use `--bold2anat-dof` instead.',
)
g_conf.add_argument(
'--bold2anat-init',
choices=['auto', 't1w', 't2w', 'header'],
Expand Down Expand Up @@ -624,12 +607,6 @@ def _str_none(val):
'Optionally, the number of grayordinate can be specified '
'(default is 91k, which equates to 2mm resolution)',
)
g_surfs_xor.add_argument(
'--fs-no-reconall',
action=DeprecatedAction,
dest='run_reconall',
help='Deprecated - use `--surface-recon-method none` instead.',
)

g_other = parser.add_argument_group('Other options')
g_other.add_argument(
Expand Down Expand Up @@ -754,12 +731,6 @@ def _str_none(val):
metavar='FILE',
help='A JSON file for customizing the derivatives queries.',
)
g_baby.add_argument(
'--force-reconall',
default=False,
action=DeprecatedAction,
help='Deprecated - use `--surface-recon-method freesurfer` instead.',
)
g_baby.add_argument(
'--surface-recon-method',
choices=('auto', 'infantfs', 'freesurfer', 'mcribs', None),
Expand Down