Skip to content

Conversation

mgxd
Copy link
Collaborator

@mgxd mgxd commented Jan 22, 2025

Hopefully the end of this mini-saga - thanks to @tsalo @mattcieslak for taking a look.

Changes included in this:

  • Fix ordering in multi-step-reg's anat2std_xfm and std2anat_xfm
  • Disassemble transform components in standalone nodes for improved transparency
  • Change inputnode fields to reflect intermediate are being used.
  • Cache intermediate <-> std transforms to node working directories.
  • Add SimpleITK as a dependency for assembling inverse std2anat xfm, until ants CompositeTransformUtil is addressed.

mgxd added 6 commits January 22, 2025 11:34
- Separate disassembly into standalone nodes for improved transparency
- Change inputnode fields to reflect intermediate
- Cache intermediate transform to node working directories
- Use SimpleITK when assembling inverse std2anat xfm
- Caught this bug while testing full workflow with:
`--output-spaces MNI152NLin6Asym` and no CIFTI outputs
@mgxd mgxd requested review from mattcieslak and tsalo January 22, 2025 16:45
Copy link
Contributor

@tsalo tsalo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one idea for a docstring and one question, really

Copy link

codecov bot commented Jan 22, 2025

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 0.37%. Comparing base (e5ed154) to head (29c87b6).
Report is 8 commits behind head on master.

Files with missing lines Patch % Lines
nibabies/workflows/base.py 0.00% 3 Missing ⚠️
nibabies/interfaces/patches.py 0.00% 1 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (e5ed154) and HEAD (29c87b6). Click for more details.

HEAD has 3 uploads less than BASE
Flag BASE (e5ed154) HEAD (29c87b6)
7 4
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #433       +/-   ##
==========================================
- Coverage   56.12%   0.37%   -55.75%     
==========================================
  Files          70      69        -1     
  Lines        6697    6581      -116     
  Branches      834     821       -13     
==========================================
- Hits         3759      25     -3734     
- Misses       2734    6556     +3822     
+ Partials      204       0      -204     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mgxd mgxd marked this pull request as ready for review January 22, 2025 17:40
@mgxd mgxd merged commit bfa91a1 into nipreps:master Jan 22, 2025
1 of 12 checks passed
@mgxd mgxd deleted the fix/composite-xfms branch January 22, 2025 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants