Skip to content

Conversation

mgxd
Copy link
Collaborator

@mgxd mgxd commented Feb 3, 2025

Closes #442

Some affine skewing may occur after DenoiseImage, which can cause the t2w mask and template to differ enough to make N4BiasCorrection upset. This ensures the mask and template have the same header prior to N4 correction leveraging the mask to localize intensity rescaling.

As of niworkflows 1.12.2, MatchHeader will just emit a warning if a significant difference is found - opened nipreps/niworkflows#924 with plans to restrict tolerance in a future release

Copy link

codecov bot commented Feb 3, 2025

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 56.44%. Comparing base (30b0d57) to head (996d704).
Report is 12 commits behind head on master.

Files with missing lines Patch % Lines
nibabies/workflows/anatomical/surfaces.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #443      +/-   ##
==========================================
- Coverage   56.45%   56.44%   -0.01%     
==========================================
  Files          70       70              
  Lines        6719     6721       +2     
  Branches      828      828              
==========================================
+ Hits         3793     3794       +1     
- Misses       2717     2718       +1     
  Partials      209      209              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mgxd mgxd marked this pull request as ready for review February 4, 2025 16:34
@mgxd mgxd merged commit 3a716e5 into nipreps:master Feb 4, 2025
15 of 16 checks passed
@mgxd mgxd deleted the fix/n4-mask branch February 4, 2025 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

N4 error in NiBabies 25.0.0

1 participant