Skip to content

Conversation

madisoth
Copy link
Contributor

Convert echo_idx to str when passing to listify (to avoid error that occurs if an int is passed)

Convert echo_idx to str when passing to listify to avoid error
Copy link

codecov bot commented Feb 13, 2025

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 56.44%. Comparing base (3a716e5) to head (1a74e29).
Report is 20 commits behind head on master.

Files with missing lines Patch % Lines
nibabies/config.py 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master     #445   +/-   ##
=======================================
  Coverage   56.44%   56.44%           
=======================================
  Files          70       70           
  Lines        6721     6721           
  Branches      828      828           
=======================================
  Hits         3794     3794           
  Misses       2718     2718           
  Partials      209      209           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Collaborator

@mgxd mgxd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the patch @madisoth - quickly looking through the ME code, I don't see a reason why echo_idx should be an integer rather than a string. Perhaps the best solution would be:

WDYT?

@mgxd
Copy link
Collaborator

mgxd commented Mar 4, 2025

After nipreps/niworkflows#925, this can be closed - thanks for catching this @madisoth

@mgxd mgxd closed this Mar 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants