Skip to content

Conversation

mgxd
Copy link
Collaborator

@mgxd mgxd commented Mar 7, 2025

Closes #393

Removes the need for a transform from MNI152NLin2009cAsym -> anatomical, as no prior will be used.

mgxd added 2 commits March 7, 2025 16:16
Additionally, fixes a bug that would use fieldmaps despite `--ignore`,
if `--use-syn-sdc` / `--force-syn` were enabled but no anatomical
estimators were found.
Copy link

codecov bot commented Mar 7, 2025

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.

Project coverage is 56.46%. Comparing base (aaa532c) to head (34348f8).
Report is 53 commits behind head on master.

Files with missing lines Patch % Lines
nibabies/workflows/base.py 0.00% 5 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master     #453   +/-   ##
=======================================
  Coverage   56.46%   56.46%           
=======================================
  Files          70       70           
  Lines        6723     6723           
  Branches      828      828           
=======================================
  Hits         3796     3796           
  Misses       2718     2718           
  Partials      209      209           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mgxd mgxd merged commit 91c5fc3 into master Apr 10, 2025
13 of 14 checks passed
@mgxd mgxd deleted the docker/test-syn branch April 10, 2025 15:10
mgxd added a commit that referenced this pull request May 19, 2025
25.0.2 (May 19, 2025)

A patch release including a couple key bug fixes:
 - Adds missing dependency to Docker image when BOLD coregistration falls back to FSL
 - Fixes connections to allow fieldmap-less SDC

Thanks to @joey-scanga for the contribution!

Documentation
  * DOC: Changed "B0Identifier" -> "B0FieldIdentifier" (#456)

Enhancements
  * ENH: Add message to show which files are to be used (#452)
  * ENH: Tag anatomical workflows (#463)

Bug Fixes
  * FIX: SyN workflow (#453)
  * FIX: Add Convert3d to Docker image (#461)

Internals / Maintenance
  * MAINT: Support sdcflows@main and smriprep >=0.18 (#462)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SyN SDC incomplete

1 participant