Merge cohort entity into space entity in derivatives#524
Merged
mgxd merged 7 commits intonipreps:masterfrom Feb 19, 2026
Merged
Merge cohort entity into space entity in derivatives#524mgxd merged 7 commits intonipreps:masterfrom
mgxd merged 7 commits intonipreps:masterfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #524 +/- ##
==========================================
- Coverage 57.21% 57.14% -0.07%
==========================================
Files 72 72
Lines 6977 6987 +10
Branches 860 863 +3
==========================================
+ Hits 3992 3993 +1
- Misses 2763 2772 +9
Partials 222 222 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mgxd
reviewed
Feb 17, 2026
Collaborator
mgxd
left a comment
There was a problem hiding this comment.
we should bump the pyproject.toml to build off smriprep master, I feel like a lot of this was covered in your smriprep PR.
btw, error was buried in CI (and not being detected..)
260216-19:15:51,604 nipype.workflow ERROR:
Node combine_space.a0 failed to run on host f2d3c5784311.
260216-19:15:51,604 nipype.workflow ERROR:
Saving crash info to /out/sub-01/ses-1mo/log/20260216-191536_2073aff4-1f47-44ef-b8e6-dcb171c8ba2c/crash-20260216-191551-UID1001-combine_space.a0-a91c9796-7a77-4a05-8709-35716e403122.txt
Traceback (most recent call last):
File "/opt/conda/envs/nibabies/lib/python3.12/site-packages/nipype/pipeline/plugins/multiproc.py", line 389, in _send_procs_to_workers
self.procs[jobid].run(updatehash=updatehash)
File "/opt/conda/envs/nibabies/lib/python3.12/site-packages/nipype/pipeline/engine/nodes.py", line 525, in run
result = self._run_interface(execute=True)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/opt/conda/envs/nibabies/lib/python3.12/site-packages/nipype/pipeline/engine/nodes.py", line 643, in _run_interface
return self._run_command(execute)
^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/opt/conda/envs/nibabies/lib/python3.12/site-packages/nipype/pipeline/engine/nodes.py", line 733, in _run_command
result.outputs = clean_working_directory(
^^^^^^^^^^^^^^^^^^^^^^^^
File "/opt/conda/envs/nibabies/lib/python3.12/site-packages/nipype/pipeline/engine/utils.py", line 1445, in clean_working_directory
output_files.extend(walk_outputs(outputdict[output]))
~~~~~~~~~~^^^^^^^^
KeyError: 'space'
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #501.
Changes proposed:
space-<space>+<cohort>in derivatives. This matches how transforms are written out, and shouldn't impact potential derivatives with the template entity (which can have the cohort entity in the filename).