-
Notifications
You must be signed in to change notification settings - Fork 5
STY: Add type hints to PET-related classes and functions #189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
d6ba066 to
a1e9842
Compare
|
I left |
119ec4e to
20eaceb
Compare
|
Failures: and So, the second one is related to the fact that |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #189 +/- ##
==========================================
+ Coverage 75.64% 75.71% +0.06%
==========================================
Files 24 24
Lines 1433 1437 +4
Branches 166 166
==========================================
+ Hits 1084 1088 +4
Misses 276 276
Partials 73 73 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
20eaceb to
635fe57
Compare
|
I am leaving out |
e144476 to
0900bff
Compare
Add type hints to PET-related classes and functions. Notably, use positional arguments instead of keyword arguments when instantiating a `namedtuple`.
0900bff to
ff4a9fa
Compare
|
Merging. Checked that the output of the notebook is the same that we get prior to the change (modulo slight differences at the beginning/end of the sequence: x-ref #204 (comment)):
Wanted to make sure due to these changes: |



Add type hints to PET-related classes and functions.