Skip to content

Conversation

@jhlegarreta
Copy link
Contributor

Validate base data objects' attributes at instantiation: ensures that the attributes are present and match the expected dimensionalities.

@jhlegarreta
Copy link
Contributor Author

jhlegarreta commented Nov 21, 2025

Cross-ref #332 (comment).

Notes: slightly different convention and naming wrt 3686a5e:

  • Suggest private functions.
  • Name functions as *validator instead of *validation (i.e. actually taking action). *validation looks better for a function name, *validator would be better for a class name.

So, cosmetic changes to be discussed.

@jhlegarreta jhlegarreta requested a review from oesteban November 21, 2025 01:25
@jhlegarreta jhlegarreta force-pushed the enh/validate-base-data-attrs branch from 9e35bdc to 8060372 Compare November 21, 2025 02:57
Validate base data objects' attributes at instantiation: ensures that
the attributes are present and match the expected dimensionalities.
@codecov
Copy link

codecov bot commented Nov 21, 2025

Codecov Report

❌ Patch coverage is 96.66667% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 78.16%. Comparing base (3f684e1) to head (d3d57fc).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
src/nifreeze/data/base.py 96.66% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #335      +/-   ##
==========================================
+ Coverage   77.57%   78.16%   +0.58%     
==========================================
  Files          28       28              
  Lines        1824     1882      +58     
  Branches      191      203      +12     
==========================================
+ Hits         1415     1471      +56     
- Misses        344      346       +2     
  Partials       65       65              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jhlegarreta jhlegarreta merged commit 965e88c into nipreps:main Nov 21, 2025
10 checks passed
@jhlegarreta jhlegarreta deleted the enh/validate-base-data-attrs branch November 21, 2025 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Ensure the dataset mandatory attributes are present in data instantiation

2 participants