Draft
Conversation
Contributor
Author
Remove the PET estimator: the `NiFreeze` estimator design is modality-agnostic, so a PET-specific estimator is not required. Remove the PET-specific integration test: checking that motion estimation with PET data yields the identity matrix when monkey patching the transformation computation when the estimator runs the registration step is covered by the `test_estimator:test_estimator_iterator_index_match` test function. Update the notebook accordingly. Avoid trying to fit on all data, as it is not implemented yet following commit a468d76.
jhlegarreta
force-pushed
the
ref/remove-pet-estimator
branch
from
1c7e6f7 to
3049c10
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #426 +/- ##
==========================================
- Coverage 83.80% 83.26% -0.54%
==========================================
Files 37 37
Lines 2136 2091 -45
Branches 235 231 -4
==========================================
- Hits 1790 1741 -49
- Misses 304 310 +6
+ Partials 42 40 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the PET estimator: the
NiFreezeestimator design is modality-agnostic, so a PET-specific estimator is not required.Remove the PET-specific integration test: checking that motion estimation with PET data yields the identity matrix when monkey patching the transformation computation when the estimator runs the registration step is covered by the
test_estimator:test_estimator_iterator_index_matchtest function.Update the notebook accordingly. Avoid trying to fit on all data, as it is not implemented yet following commit a468d76.