ENH: Update LOVO splitter to new dataset indexed access #57
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #57 +/- ##
==========================================
- Coverage 67.60% 67.45% -0.16%
==========================================
Files 20 20
Lines 991 977 -14
Branches 131 129 -2
==========================================
- Hits 670 659 -11
+ Misses 267 265 -2
+ Partials 54 53 -1 ☔ View full report in Codecov by Sentry. |
oesteban
force-pushed
the
enh/generalize-lovo-splitter
branch
2 times, most recently
from
81021ba to
052aa0e
Compare
jhlegarreta
approved these changes
Jan 20, 2025
Contributor
jhlegarreta
left a comment
jhlegarreta
left a comment
There was a problem hiding this comment.
Thanks for doing this 💯.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Leverage the new
__getitem__interface, which provides uniform indexed access across modalities.Requires: #52.
Related-To: #19.
Resolves: #20.