MAINT: Update minimum required scikit-learn version to 1.3.0
#58
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update minimum required `scikit-learn` version to 1.3.0 (released June 2023): - 0.18 dates back to Sept 28, 2016 (9 years ago): https://scikit-learn.org/1.6/whats_new/v0.18.html#changes-0-18 - CI testing is using 1.6.0, the most recent version to date: https://scikit-learn.org/1.6/whats_new/v1.6.html - Following the errors discovered during the type hinting efforts, the `DiffusionGPR` class is accepting the `n_targets` named parameter constraint, which was introduced in `scikit-learn` version 1.3.0: https://scikit-learn.org/1.6/whats_new/v1.3.html#sklearn-gaussian-process Documentation: https://scikit-learn.org/1.6/whats_new/v1.3.html#version-1-3-0
Contributor
Author
|
X-ref: #28 (comment) |
oesteban
approved these changes
Jan 20, 2025
oesteban
changed the title
scikit-learn version to 1.3.0scikit-learn version to 1.3.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update minimum required
scikit-learnversion to 1.3.0 (released June 2023):DiffusionGPRclass is accepting then_targetsnamed parameter constraint, which was introduced inscikit-learnversion 1.3.0: https://scikit-learn.org/1.6/whats_new/v1.3.html#sklearn-gaussian-processDocumentation:
https://scikit-learn.org/1.6/whats_new/v1.3.html#version-1-3-0