ENH: Miscellaneous improvements to the Reports #357
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- [x] Resizing of reportlets: now reportlets can be either static or
dynamic. Static reportlets are embedded in ``<img>`` tags, which are
easier to resize (CSS works just fine). Conversely, dynamic reportlets
are embedded in ``<object>`` tags, which are more finicky and
require proper settings of ``height``, ``width``, ``viewBox`` and
``preserveAspectRatio``. Animations do not work within ``<img>`` tags.
- [x] Better ordering of functional subreports.
- [x] Improved subtitles and other minor amends.
oesteban
added a commit
to oesteban/fmriprep
that referenced
this pull request
May 3, 2019
rwblair
approved these changes
May 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds upon #344, #346, #349, #351, and #352
<img>tags, which are easier to resize (CSS works just fine). Conversely, dynamic reportlets are embedded in<object>tags, which are more finicky and require proper settings ofheight,width,viewBoxandpreserveAspectRatio. Animations do not work within<img>tags.