Skip to content

Conversation

oesteban
Copy link
Member

Removes the "project" target from comments in PRs because the segregated
testing of niworkflows (masks, pytests, reportlets, ...) makes almost
all PRs to be under a decent project threshold (and hence show up as
failed).

@pull-assistant
Copy link

pull-assistant bot commented Apr 29, 2020

Score: 1.00

Best reviewed: commit by commit


Optimal code review plan

     chore(codecov): add codecov config file to reduce noise [skip ci]

Powered by Pull Assistant. Last update bfc407e ... bfc407e. Read the comment docs.

@oesteban oesteban requested review from effigies and mgxd April 29, 2020 16:48
@effigies
Copy link
Member

Could you show an example of what you're trying to avoid?

@oesteban
Copy link
Member Author

Example #506 - this will hide the codecov/project check from the list and show up as building okay in github.

@effigies
Copy link
Member

Oh, got it. Right, I forgot that we don't run all the tests on PRs.

@effigies
Copy link
Member

This is fine by me.

Removes the "project" target from comments in PRs because the segregated
testing of niworkflows (masks, pytests, reportlets, ...) makes almost
all PRs to be under a decent project threshold (and hence show up as
failed).
@oesteban oesteban force-pushed the maint/codecov-config branch from 0de02a4 to bfc407e Compare April 29, 2020 18:59
@oesteban oesteban merged commit 98ff359 into nipreps:master Apr 29, 2020
@oesteban oesteban deleted the maint/codecov-config branch April 29, 2020 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants