Skip to content

Conversation

oesteban
Copy link
Member

Resolves: #787.

@oesteban oesteban force-pushed the maint/finalize-porting-of-vrs branch 4 times, most recently from 955a4d5 to 48646ee Compare March 12, 2023 20:12
@oesteban oesteban force-pushed the maint/finalize-porting-of-vrs branch from 48646ee to f1adf7e Compare March 12, 2023 20:17
@codecov-commenter
Copy link

codecov-commenter commented Mar 12, 2023

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 60.49%. Comparing base (c2b8e0f) to head (f1adf7e).
⚠️ Report is 418 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #789      +/-   ##
==========================================
- Coverage   63.39%   60.49%   -2.90%     
==========================================
  Files          49       42       -7     
  Lines        5963     4863    -1100     
  Branches     1170      943     -227     
==========================================
- Hits         3780     2942     -838     
+ Misses       2001     1808     -193     
+ Partials      182      113      -69     
Flag Coverage Δ
reportlettests ∅ <ø> (∅)
unittests 55.01% <ø> (+4.35%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@effigies
Copy link
Member

effigies commented Mar 12, 2023

I would specifically not like to depend on nireports. I would just deprecate and not shim. We stop fixing things here, and in a year or so we just remove.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Finalize the migration of visual elements to NiReports
3 participants