Skip to content

fix(test): CIFTI2 expected checksum has changed #895

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 31, 2024
Merged

fix(test): CIFTI2 expected checksum has changed #895

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 11 additions & 5 deletions niworkflows/interfaces/tests/test_bids.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@
import nibabel as nb
import pytest
from nipype.interfaces.base import Undefined
from packaging.version import Version

from .. import bids as bintfs
from niworkflows.testing import needs_data_dir
Expand Down Expand Up @@ -211,7 +212,7 @@ def connect_and_run_save(prep_result, save):
{"space": "fsLR", "density": "91k"},
"sub-100185/func/sub-100185_task-machinegame_run-01_"
"space-fsLR_den-91k_bold.dtseries.nii",
"f7b8755c6ad0d8dcdb60676331b52a23ce288b61",
"335f1394ce90b58bbf27026b6eeec4d2124c11da",
),
(
BOLD_PATH,
Expand Down Expand Up @@ -374,10 +375,15 @@ def test_DerivativesDataSink_build_path(
assert not np.isnan(hdr["scl_slope"])
assert not np.isnan(hdr["scl_inter"])
for out, chksum in zip(output, checksum):
if chksum == "f7b8755c6ad0d8dcdb60676331b52a23ce288b61" and sys.version_info < (3, 8):
# Python 3.8 began preserving insertion order of attributes in XML
# Therefore we get a different checksum before/after
chksum = "a37ffb1188dd9a7b708de5b8daef46dac56ef8d4"
if chksum == "335f1394ce90b58bbf27026b6eeec4d2124c11da":
if sys.version_info < (3, 8):
# Python 3.8 began preserving insertion order of attributes in XML
# Therefore we get a different checksum before/after
chksum = "a37ffb1188dd9a7b708de5b8daef46dac56ef8d4"
elif Version(nb.__version__) < Version('5.3'):
# Nibabel 5.3 avoids unnecessary roundtrips for Cifti2Headers
# Older versions transformed a `SeriesStep="2"` into `SeriesStep="2.0"`
chksum = "f7b8755c6ad0d8dcdb60676331b52a23ce288b61"
assert sha1(Path(out).read_bytes()).hexdigest() == chksum


Expand Down
Loading