Skip to content

Conversation

@effigies
Copy link
Member

@effigies effigies commented Nov 21, 2024

Apologies for the massive diff. I recommend a per-commit review, ignoring the safe reformats/syntax twiddles in the ruff format and ruff check --fix commits.

@codecov
Copy link

codecov bot commented Nov 21, 2024

Codecov Report

Attention: Patch coverage is 69.32453% with 604 lines in your changes missing coverage. Please review.

Project coverage is 69.37%. Comparing base (4984e53) to head (baf9310).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
niworkflows/anat/ants.py 9.52% 57 Missing ⚠️
niworkflows/interfaces/surf.py 46.66% 39 Missing and 1 partial ⚠️
niworkflows/interfaces/header.py 55.55% 35 Missing and 1 partial ⚠️
niworkflows/interfaces/norm.py 43.33% 34 Missing ⚠️
niworkflows/interfaces/images.py 62.50% 32 Missing and 1 partial ⚠️
niworkflows/interfaces/freesurfer.py 58.82% 28 Missing ⚠️
niworkflows/interfaces/nibabel.py 73.52% 27 Missing ⚠️
niworkflows/anat/coregistration.py 10.71% 25 Missing ⚠️
niworkflows/interfaces/itk.py 31.42% 24 Missing ⚠️
niworkflows/func/util.py 25.00% 21 Missing ⚠️
... and 38 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #904      +/-   ##
==========================================
+ Coverage   69.35%   69.37%   +0.02%     
==========================================
  Files          86       86              
  Lines        8451     8468      +17     
  Branches     1057     1057              
==========================================
+ Hits         5861     5875      +14     
- Misses       2367     2370       +3     
  Partials      223      223              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@effigies effigies merged commit 0f5b65b into nipreps:master Nov 22, 2024
18 of 19 checks passed
@effigies effigies deleted the sty/ruff branch November 22, 2024 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done (To be released)

Development

Successfully merging this pull request may close these issues.

1 participant