Allow + symbol in label entities #926
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #926 +/- ##
=======================================
Coverage 69.40% 69.40%
=======================================
Files 86 86
Lines 8483 8483
Branches 1059 1059
=======================================
Hits 5888 5888
Misses 2373 2373
Partials 222 222 ☔ View full report in Codecov by Sentry. |
effigies
approved these changes
Feb 25, 2025
mgxd
reviewed
Feb 25, 2025
| { | ||
| "name": "from", | ||
| "pattern": "(?:^|_)from-([a-zA-Z0-9\\+]+).*xfm" | ||
| "pattern": "(?:^|_)from-([a-zA-Z0-9+\\+]+).*xfm" |
There was a problem hiding this comment.
to from and space already handled the + character, though we can clean these up to simply
Suggested change
| "pattern": "(?:^|_)from-([a-zA-Z0-9+\\+]+).*xfm" | |
| "pattern": "(?:^|_)from-([a-zA-Z0-9+]+).*xfm" |
There was a problem hiding this comment.
Sorry about that! I just did a find and replace. Since this was already merged I can open a PR to fix this.
effigies
added a commit
that referenced
this pull request
Mar 20, 2025
1.13.0 (March 20, 2025) New feature release in the 1.13.x series. This release restructures the ANTs brain extraction workflow. This should be a backwards compatible change, but a minor release is used out of caution. * FIX: Remove duplicated code, problematic deviation from antsBrainExtraction (#931) * FIX: Listify numbers (#925) * ENH: Allow + symbol in label entities (#926, #927) * STY: Apply various ruff checks (#913, #915, #917, #918, #919, #930)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stems from bids-standard/bids-specification#1926, which will take effect in the next BIDS release (v1.11.0).
Changes proposed:
+symbol to the regular expressions for label-based entities innipreps.json.