STY: Enable more ruff rules #930
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DimitriPapadopoulos
force-pushed
the
ruff
branch
2 times, most recently
from
3923cbd to
010635e
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #930 +/- ##
=======================================
Coverage 69.37% 69.37%
=======================================
Files 86 86
Lines 8474 8474
Branches 1057 1057
=======================================
Hits 5879 5879
Misses 2373 2373
Partials 222 222 ☔ View full report in Codecov by Sentry. |
effigies
approved these changes
Mar 2, 2025
G004 Logging statement uses f-string
RUF015 Prefer `next(...)` over single element slice
RUF021 Parenthesize `a and b` expressions when chaining `and` and `or` together, to make the precedence clear
RUF055 Plain string pattern passed to `re` function
F841 Local variable is assigned to but never used
PLE1205 Too many arguments for `logging` format string
PLW1508 Invalid type for environment variable default; expected `str` or `None`
DimitriPapadopoulos
force-pushed
the
ruff
branch
from
a75cc1a to
3a8e7bf
Compare
Co-authored-by: Chris Markiewicz <[email protected]>
Fix CI error.
DimitriPapadopoulos
force-pushed
the
ruff
branch
from
bda3bf0 to
a7249c3
Compare
effigies
added a commit
that referenced
this pull request
Mar 20, 2025
1.13.0 (March 20, 2025) New feature release in the 1.13.x series. This release restructures the ANTs brain extraction workflow. This should be a backwards compatible change, but a minor release is used out of caution. * FIX: Remove duplicated code, problematic deviation from antsBrainExtraction (#931) * FIX: Listify numbers (#925) * ENH: Allow + symbol in label entities (#926, #927) * STY: Apply various ruff checks (#913, #915, #917, #918, #919, #930)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.