FIX: Update reference-mask reportlet queries

Author: mnoergaard

petprep/data/reports-spec-pet.yml

@@ -9,7 +9,7 @@ sections:
   - bids: {datatype: figures, desc: carpetplot, suffix: pet}
   - bids: {datatype: figures, desc: confoundcorr, suffix: pet}
   - bids: {datatype: figures, desc: coreg, suffix: pet}
-  - bids: {datatype: figures, desc: refmask, suffix: pet}
+  - bids: {datatype: figures, desc: ref, suffix: pet}
     caption: Reference region mask overlaid on the PET reference and anatomical data.
     static: false
     subtitle: Reference mask check

petprep/data/reports-spec.yml

@@ -138,7 +138,7 @@ sections:
     caption: PET to anatomical alignment check
     static: false
     subtitle: Additional PET Visualizations
-  - bids: {datatype: figures, desc: refmask, suffix: pet}
+  - bids: {datatype: figures, desc: ref, suffix: pet}
     caption: Reference region mask overlaid on the PET reference and anatomical.
     static: false
     subtitle: Reference mask check

petprep/workflows/pet/tests/test_fit.py

@@ -223,8 +223,8 @@ def test_refmask_report_connections(bids_root: Path, tmp_path: Path, pvc_method)
 
     assert 'ds_refmask_wf.ds_refmask' in wf.list_node_names()
     ref_ds = wf.get_node('ds_refmask_wf').get_node('ds_refmask')
-    assert ref_ds.inputs.desc == 'refmask'
-    assert ref_ds.inputs.ref == 'cerebellum'
+    assert ref_ds.inputs.desc == 'ref'
+    assert ref_ds.inputs.label == 'cerebellum'
     assert 'func_fit_reports_wf.pet_t1_refmask_report' in wf.list_node_names()
     reports_node = wf.get_node('func_fit_reports_wf')
     edge = wf._graph.get_edge_data(wf.get_node('outputnode'), reports_node)
@@ -360,8 +360,8 @@ def test_init_refmask_report_wf(tmp_path: Path):
     wf = init_refmask_report_wf(output_dir=str(tmp_path), ref_name='test')
     assert 'mask_report' in wf.list_node_names()
     ds = wf.get_node('ds_report_refmask')
-    assert ds.inputs.desc == 'refmask'
-    assert ds.inputs.ref == 'test'
+    assert ds.inputs.desc == 'ref'
+    assert ds.inputs.label == 'test'
     assert ds.inputs.suffix == 'pet'
 
 
@@ -370,7 +370,11 @@ def test_reports_spec_contains_refmask():
     for fname in ('reports-spec.yml', 'reports-spec-pet.yml'):
         spec = yaml.safe_load((data.load.readable(fname)).read_text())
         pet_section = next(s for s in spec['sections'] if s['name'] == 'PET')
-        assert any(r.get('bids', {}).get('desc') == 'refmask' for r in pet_section['reportlets'])
+        assert any(
+            r.get('bids', {}).get('desc') == 'ref'
+            and 'label' not in r.get('bids', {})
+            for r in pet_section['reportlets']
+        )
 
 
 def test_refmask_reports_omitted(bids_root: Path, tmp_path: Path):