Skip to content

Conversation

@mgxd
Copy link
Contributor

@mgxd mgxd commented May 4, 2020

@pull-assistant
Copy link

pull-assistant bot commented May 4, 2020

Score: 1.00

Best reviewed: commit by commit


Optimal code review plan

     FIX: backport niworkflows utility function

Powered by Pull Assistant. Last update 0df1b24 ... 0df1b24. Read the comment docs.

@pep8speaks
Copy link

pep8speaks commented May 4, 2020

Hello @mgxd, Thank you for updating!

Cheers! There are no style issues detected in this Pull Request. 🍻 To test for issues locally, pip install flake8 and then run flake8 sdcflows.

Comment last updated at 2020-05-04 16:49:54 UTC

@oesteban
Copy link
Member

oesteban commented May 4, 2020

Wouldn't this backport pertain to niworkflows?

@mgxd
Copy link
Contributor Author

mgxd commented May 4, 2020

We could go about it either way? This seems like the easier route IMO, and should be replaced once we go bump to 1.3.0

@oesteban
Copy link
Member

oesteban commented May 4, 2020

I believe this function is also used in smriprep and I think that we will need to also backport there if we want to be able to progress after 0.5.2 in the 0.5.x series.

@mgxd
Copy link
Contributor Author

mgxd commented May 4, 2020

shouldn't be necessary as smriprep 0.5.x series is pinned to niworkflows 1.1.x. (all these different versions are making our dependency matrix more complex than necessary, which led to this proposal in nipreps/fmriprep#2054 (comment))

@mgxd
Copy link
Contributor Author

mgxd commented May 4, 2020

closing and releasing from the maint/1.2.x branch.

no need to include this in master.

@mgxd mgxd closed this May 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants