[FIX] Fixes conditions of overlapping B0FieldIdentifier, resulting in no estimators #497
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## maint/2.13.x #497 +/- ##
=============================================
Coverage 84.09% 84.09%
=============================================
Files 30 30
Lines 2880 2880
Branches 374 374
=============================================
Hits 2422 2422
Misses 384 384
Partials 74 74 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mgxd
left a comment
mgxd
left a comment
There was a problem hiding this comment.
Looks reasonable - having trouble tracking all the parsing going on in wrangler.py / fieldmap.py, could you include a test?
|
seems like B0Field* are not tested in test_wrangler, will try to implement common case and this edge one. |
bpinsard
force-pushed
the
fix/overlapping_b0fieldIds
branch
4 times, most recently
from
2e6beff to
fe315d6
Compare
|
OSF maintenance is preventing the tests to run https://fosstodon.org/@CenterforOpenScience |
|
The tests, look good to me, Is there any chance this will be in the next release? |
effigies
left a comment
effigies
left a comment
There was a problem hiding this comment.
Looks pretty straightforward.
effigies
changed the title
effigies
force-pushed
the
fix/overlapping_b0fieldIds
branch
from
fe315d6 to
a42eef3
Compare
2.13.2 (July 28, 2025) Patch release in the 2.13.x series. This includes a fix for cases where a scan contributes to multiple `B0FieldIdentifier`s. * [FIX] Fixes conditions of overlapping B0FieldIdentifier, resulting in no estimators (#497)
4 participants
fixes nipreps/fmriprep#3484
Simply forces the estimator to be named after the BIDS-set B0FieldIdentifier.