FIX: Progress partial volume maps instead of posteriors (FSL FAST) #213
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Selects the PVE maps and PVE MAP segmentation from FSL FAST to forward it through the workflow. PVE maps are smoother (due to the regularization of the MRF), and they are actually used by aCompCor in its original implementation by Behzadi (see nipreps/fmriprep#2129). This PR changes the contents of some derivatives and therefore targets the next minor release. Resolves: nipreps#212.
|
Best reviewed: commit by commit
Optimal code review plan
|
Codecov Report
@@ Coverage Diff @@
## master #213 +/- ##
===========================================
- Coverage 71.48% 25.60% -45.89%
===========================================
Files 15 15
Lines 996 996
Branches 136 136
===========================================
- Hits 712 255 -457
- Misses 237 731 +494
+ Partials 47 10 -37
Continue to review full report at Codecov.
|
Member
Author
|
I've checked locally and this works fine. It looks pretty uncontroversial and merging will help me better address nipreps/fmriprep#2130, so I'll go ahead and merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Selects the PVE maps and PVE MAP segmentation from FSL FAST to forward it through the workflow. PVE maps are smoother (due to the regularization of the MRF), and they are actually used by aCompCor in its original implementation by Behzadi (see nipreps/fmriprep#2129).
This PR changes the contents of some derivatives and therefore targets the next minor release.
Resolves: #212.