Skip to content

BF:Change nipype required version to >=1.0.0 #364

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 7, 2019
Merged

BF:Change nipype required version to >=1.0.0 #364

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion heudiconv/info.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
REQUIRES = [
'nibabel',
'pydicom',
'nipype>=0.12.0',
'nipype>=1.0.0',
'pathlib',
'dcmstack>=0.7',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should fix the test. lxml did not set a python_requires when they broke 3.4 compatibility.

Suggested change
'dcmstack>=0.7',
'dcmstack>=0.7',
'lxml<4.4.0; python_version == "3.4"',

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, looks like @mgxd got here first.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yarikoptic - are you okay with dropping support for 0.x nipype? I am.

yes -- let's look forward!

re lxml -- should we just stop carrying about 3.4? Even Debian stable has 3.7 nowadays ;)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm all for removing 3.4 from our testing suite!!!

]
Expand Down