FIX: Testing for extension/signature mismatches shouldn't use sniff #1138
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1138 +/- ##
==========================================
- Coverage 91.80% 91.80% -0.01%
==========================================
Files 101 101
Lines 12454 12453 -1
Branches 2433 2432 -1
==========================================
- Hits 11434 11433 -1
Misses 693 693
Partials 327 327
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
@Sikerdebaard Would you care to try this branch out? |
|
This code works in my particular environment. The new unit test case also succeeds. Looks good to me. :) Any idea in what version this fix will be merged? I've monkeypatched it for current versions, but I'd like to add a version check so that it doesn't monkeypatch starting at the fixed version. |
|
The next release will be 5.0.0. Thanks for looking it over and testing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug introduced in #1013 and reported in #1137. Added a test that fails with an unexpected error, and then updated
_signature_matches_extensionto not accept anysniff. (If the file was compressed, the sniff would be read from the uncompressed stream. If it wasn't compressed, the sniff would be empty.)Some updates to make the same machinery work transparently for
.zst.Closes #1137.