RF: Rely on stdlib implementations for tmpdirs tools #1172
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that we have almost an identical implementation of
TemporaryDirectory
as the stdlib (https://docs.python.org/3/library/tempfile.html#tempfile.TemporaryDirectory), so I scheduled it for deprecation and removal.With the coming chdir context manager, the remaining tools can be made convenience wrappers on stdlib 1-or-2 liners, so I went ahead and did it. IMO it's a bit cleaner to read a single function with the setup-yield-teardown structure than a two-or-three method class.